Merge lp:~ibm-demo/charms/trusty/juju-gui/trunk into lp:charms/juju-gui

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 101
Proposed branch: lp:~ibm-demo/charms/trusty/juju-gui/trunk
Merge into: lp:charms/juju-gui
Diff against target: 63 lines (+18/-1)
3 files modified
config.yaml (+4/-0)
metadata.yaml (+1/-1)
tests/tests.yaml (+13/-0)
To merge this branch: bzr merge lp:~ibm-demo/charms/trusty/juju-gui/trunk
Reviewer Review Type Date Requested Status
Richard Harding Approve
Review via email: mp+240048@code.launchpad.net

Description of the change

1. Update config.yaml to pass `charm proof`
2. Update tests.yaml so that tests are executed properly (and pass!) when run by the automated test runner. For more info on the automated test runner see: http://blog.juju.solutions/cloud/juju/2014/10/02/charm-testing.html

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-04-15 14:17:12 +0000
+++ config.yaml 2014-10-29 19:39:45 +0000
@@ -66,17 +66,20 @@
66 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.66 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.
67 If not, cetificates will be automatically generated.67 If not, cetificates will be automatically generated.
68 type: string68 type: string
69 default:
69 ssl-key-contents:70 ssl-key-contents:
70 description: |71 description: |
71 The contents of the private key file to be used in SSL connections to72 The contents of the private key file to be used in SSL connections to
72 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.73 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.
73 If not, cetificates will be automatically generated.74 If not, cetificates will be automatically generated.
74 type: string75 type: string
76 default:
75 login-help:77 login-help:
76 description: |78 description: |
77 The help text shown to the user on the login screen. If not provided, a79 The help text shown to the user on the login screen. If not provided, a
78 default message is used, suggesting how to find the login credentials.80 default message is used, suggesting how to find the login credentials.
79 type: string81 type: string
82 default:
80 read-only:83 read-only:
81 description: |84 description: |
82 Whether or not the GUI is in read-only mode. Note that read-only mode is85 Whether or not the GUI is in read-only mode. Note that read-only mode is
@@ -103,6 +106,7 @@
103 If given, the password to use for the environment to immediately106 If given, the password to use for the environment to immediately
104 connect. Do not set unless you understand and accept the risks.107 connect. Do not set unless you understand and accept the risks.
105 type: string108 type: string
109 default:
106 sandbox:110 sandbox:
107 description: |111 description: |
108 Run using an in-memory sandbox rather than a real Juju backend. Sandbox112 Run using an in-memory sandbox rather than a real Juju backend. Sandbox
109113
=== modified file 'metadata.yaml'
--- metadata.yaml 2013-07-29 21:39:43 +0000
+++ metadata.yaml 2014-10-29 19:39:45 +0000
@@ -18,7 +18,7 @@
18summary: User interface for Juju (development)18summary: User interface for Juju (development)
19maintainer: Juju GUI Team <juju-gui@lists.launchpad.net>19maintainer: Juju GUI Team <juju-gui@lists.launchpad.net>
20description: Web GUI for Juju20description: Web GUI for Juju
21categories: ["applications"]21tags: ["ops"]
22provides:22provides:
23 web:23 web:
24 interface: http24 interface: http
2525
=== added file 'tests/tests.yaml'
--- tests/tests.yaml 1970-01-01 00:00:00 +0000
+++ tests/tests.yaml 2014-10-29 19:39:45 +0000
@@ -0,0 +1,13 @@
1bootstrap: false
2reset: false
3tests: "none"
4packages:
5 - build-essential
6 - bzr
7 - libapt-pkg-dev
8 - libpython-dev
9 - python-virtualenv
10 - rsync
11 - xvfb
12 - charm-tools
13 - firefox

Subscribers

People subscribed via source and target branches