Juju Charms Collection
nova-cloud-controller package

Code review comment for lp:~gnuoy/charms/trusty/nova-cloud-controller/add-console-access

  1. Trusty Tahr (14.04)
  2. add-console-access
  3. Merge into next
Revision history for this message
Liam Young (gnuoy) wrote :

> I think this is fine as a function of the nova-cc charm; I've made a couple of
> comments.
>

I've made the changes you suggested

> One other question - does this work OK when more that one nova-cc service unit
> is being used? I'm not familiar with how this part of openstack actually
> works. Right now, users would always be directed to the unit serving the VIP
> and would not be load balanced - but this might actually be the right
> behaviour!

I think this is behaviour is fine tbh. I've had a play with an ha setup and the client handshake fails. I haven't looked into to much further (maybe sticky haproxy sessions are needed). If you have no objection I'll create a wishlist bug and grab it to look at ha further but I'm not convinced it will work.

review: Needs Resubmitting

« Back to merge proposal