dpb[0 & 1]:
- test isolation and makefile fixes have been made to ensure -j3 is run during unit tests. had to drop global mocker.replace("path.to.module") and instead mock.patch local methods/functions to avoid collisions with running in multiple threads
- Resolved in this branch to actually call DescribeVolumes() and DescribeInstances() during _ec2_describe_volumes and _ec2_describe_instances respectively so that we ensure load_environment is called 1st. importing these classes directly from euca2ools is a no-no and broke us on trusty. The trusty support branch mentioned about drops these imports completely in favor of parsing the euca commandline tool output.
Thanks for the reviews guys:
dpb[0 & 1]: replace( "path.to. module" ) and instead mock.patch local methods/functions to avoid collisions with running in multiple threads
- test isolation and makefile fixes have been made to ensure -j3 is run during unit tests. had to drop global mocker.
[2] trusty failures: /code.launchpad .net/~chad. smith/charms/ precise/ block-storage- broker/ bsb-trusty- support/ +merge/ 211963
- they are resolved in a followon MP: at https:/
dpb[3] in StrogaeServiceU til.__init_ _, the environment needs to be loaded
before:
self. ec2_instances_ command = getinstances. DescribeInstanc es() ec2_volumes_ command = getvolumes. DescribeVolumes ()
self.
- Resolved in this branch to actually call DescribeVolumes() and DescribeInstances() during _ec2_describe_ volumes and _ec2_describe_ instances respectively so that we ensure load_environment is called 1st. importing these classes directly from euca2ools is a no-no and broke us on trusty. The trusty support branch mentioned about drops these imports completely in favor of parsing the euca commandline tool output.