Code review comment for lp:~chad.smith/charms/precise/block-storage-broker/bsb-ec2-support

Revision history for this message
David Britton (dpb) wrote :

[2] per discussions in IRC, trusty gets this failure. follow-on work in a separate branch, I guess. :(

test_util.TestEC2Util.test_wb_ec2_describe_volumes_without_attached_instances
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/dist-packages/mocker.py", line 146, in test_method_wrapper
    result = test_method()
  File "/home/dpb/src/canonical/juju/charms/blockstoragebroker/bsb-ec2-support/hooks/test_util.py", line 1332, in test_wb_ec2_describe_volumes_with_attac
hed_instances
    self.storage._ec2_describe_volumes(), expected)
  File "/home/dpb/src/canonical/juju/charms/blockstoragebroker/bsb-ec2-support/hooks/util.py", line 250, in _ec2_describe_volumes
    command = describevolumes.DescribeVolumes()
  File "/usr/lib/python2.7/dist-packages/euca2ools/commands/euca/__init__.py", line 213, in __init__
    AWSQueryRequest.__init__(self, **kwargs)
  File "/usr/lib/python2.7/dist-packages/requestbuilder/request.py", line 88, in __init__
    BaseCommand.__init__(self, **kwargs)
  File "/usr/lib/python2.7/dist-packages/requestbuilder/command.py", line 98, in __init__
    self._post_init()
  File "/usr/lib/python2.7/dist-packages/requestbuilder/request.py", line 94, in _post_init
    BaseCommand._post_init(self)
  File "/usr/lib/python2.7/dist-packages/requestbuilder/command.py", line 107, in _post_init
    self.configure()
  File "/usr/lib/python2.7/dist-packages/requestbuilder/request.py", line 107, in configure
    self.service.configure()
  File "/usr/lib/python2.7/dist-packages/euca2ools/commands/euca/__init__.py", line 199, in configure
    self.validate_config()
  File "/usr/lib/python2.7/dist-packages/requestbuilder/service.py", line 154, in validate_config
    raise ServiceInitError(msg)
requestbuilder.exceptions.ServiceInitError: No ec2 endpoint to connect to was given. ec2 endpoints may be specified in a config file with "ec2-url".

test_util.TestEC2Util.test_wb_ec2_describe_volumes_with_attached_instances
-------------------------------------------------------------------------------
Ran 77 tests in 0.205s

FAILED (errors=4, successes=73)
make: *** [test] Error 1

« Back to merge proposal