Code review comment for lp:~canonical-is-sa/charms/trusty/kibana/trunk

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hey there Michael. I'm just looking at this charm change, and it looks like upstream has already changed the web relation to 'http'. So I think that part is done. There are two other features you've included - the elasticsearch url config option, and the exec.d support.

I'll give you an MP to merge into your canonical-is-sa branch which re-merges trunk, so we can push those two options up for review again.

« Back to merge proposal