Juju Charms Collection
kibana package

Code review comment for lp:~canonical-is-sa/charms/trusty/kibana/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Michael,

I had a chance to review this merge proposal today. Thanks for your work on improving the kibana charm!

`charm proof` alerted me to 'hooks/website-relation-joined' not being executable. That's not a blocker, as juju should do the right thing, but is an easy fix.

With a new feature such as this, I look for two things that I'm not seeing: some documentation about the new feature in the README, and a test to exercise it. If you could address both of those issues, I'll happily approve this merge.

Thanks once again for your work on this!

review: Needs Fixing

« Back to merge proposal