Merge lp:~brian-murray/arsenal/days-with-importance into lp:~bryce/arsenal/2.x

Proposed by Brian Murray
Status: Merged
Merged at revision: 1086
Proposed branch: lp:~brian-murray/arsenal/days-with-importance
Merge into: lp:~bryce/arsenal/2.x
Diff against target: 90 lines (+24/-0)
1 file modified
scripts/collect-bug-data (+24/-0)
To merge this branch: bzr merge lp:~brian-murray/arsenal/days-with-importance
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Review via email: mp+115216@code.launchpad.net

Description of the change

I discovered that you can't search on importance with collect-bug-data so I fixed that. I also added in searching for how long a bug has had it's importance set.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/collect-bug-data'
--- scripts/collect-bug-data 2012-07-10 16:15:03 +0000
+++ scripts/collect-bug-data 2012-07-16 19:55:22 +0000
@@ -307,6 +307,12 @@
307 Dbg.verbose('search: status: \'%s\'\n' % ','.join(search_status))307 Dbg.verbose('search: status: \'%s\'\n' % ','.join(search_status))
308308
309 try:309 try:
310 search_importance = search_criteria['importance']
311 except KeyError:
312 search_importance = []
313 Dbg.verbose('search: importance: \'%s\'\n' % ','.join(search_importance))
314
315 try:
310 search_order = search_criteria['order_by']316 search_order = search_criteria['order_by']
311 except KeyError:317 except KeyError:
312 search_order = '-datecreated'318 search_order = '-datecreated'
@@ -344,6 +350,11 @@
344 except KeyError:350 except KeyError:
345 statuslength = False351 statuslength = False
346352
353 try:
354 implength = search_criteria['days-with-importance']
355 except KeyError:
356 implength = False
357
347 # ensure that only one of these are selected358 # ensure that only one of these are selected
348 count = 0359 count = 0
349 if search_assignees != '':360 if search_assignees != '':
@@ -362,6 +373,7 @@
362 search_args = {'tags': search_tags,373 search_args = {'tags': search_tags,
363 'tags_combinator': search_tags_combinator,374 'tags_combinator': search_tags_combinator,
364 'status': search_status,375 'status': search_status,
376 'importance': search_importance,
365 'modified_since': last_run_time,377 'modified_since': last_run_time,
366 'order_by': search_order}378 'order_by': search_order}
367379
@@ -376,6 +388,8 @@
376 tasks.set_filter_reopened()388 tasks.set_filter_reopened()
377 if statuslength:389 if statuslength:
378 tasks.set_filter_status_length(statuslength)390 tasks.set_filter_status_length(statuslength)
391 if implength:
392 tasks.set_filter_status_length(implength)
379 reported_tasks.append(tasks)393 reported_tasks.append(tasks)
380 else:394 else:
381 for participant in search_reporter.participants:395 for participant in search_reporter.participants:
@@ -387,6 +401,8 @@
387 tasks.set_filter_reopened()401 tasks.set_filter_reopened()
388 if statuslength:402 if statuslength:
389 tasks.set_filter_status_length(statuslength)403 tasks.set_filter_status_length(statuslength)
404 if implength:
405 tasks.set_filter_status_length(implength)
390 for task in tasks:406 for task in tasks:
391 reported_tasks.append(task)407 reported_tasks.append(task)
392 if search_limit:408 if search_limit:
@@ -404,6 +420,8 @@
404 tasks.set_filter_reopened()420 tasks.set_filter_reopened()
405 if statuslength:421 if statuslength:
406 tasks.set_filter_status_length(statuslength)422 tasks.set_filter_status_length(statuslength)
423 if implength:
424 tasks.set_filter_status_length(implength)
407 assigned_tasks.append(tasks)425 assigned_tasks.append(tasks)
408 search_assignee_names.append(search_assignee.name)426 search_assignee_names.append(search_assignee.name)
409 else:427 else:
@@ -416,6 +434,8 @@
416 tasks.set_filter_reopened()434 tasks.set_filter_reopened()
417 if statuslength:435 if statuslength:
418 tasks.set_filter_status_length(statuslength)436 tasks.set_filter_status_length(statuslength)
437 if implength:
438 tasks.set_filter_status_length(implength)
419 for task in tasks:439 for task in tasks:
420 assigned_tasks.append(task)440 assigned_tasks.append(task)
421 if search_limit:441 if search_limit:
@@ -434,6 +454,8 @@
434 tasks.set_filter_reopened()454 tasks.set_filter_reopened()
435 if statuslength:455 if statuslength:
436 tasks.set_filter_status_length(statuslength)456 tasks.set_filter_status_length(statuslength)
457 if implength:
458 tasks.set_filter_status_length(implength)
437 if search_limit:459 if search_limit:
438 return tasks[:search_limit]460 return tasks[:search_limit]
439 else:461 else:
@@ -444,6 +466,8 @@
444 tasks.set_filter_reopened()466 tasks.set_filter_reopened()
445 if statuslength:467 if statuslength:
446 tasks.set_filter_status_length(statuslength)468 tasks.set_filter_status_length(statuslength)
469 if implength:
470 tasks.set_filter_status_length(implength)
447 if search_limit:471 if search_limit:
448 return tasks[:search_limit]472 return tasks[:search_limit]
449 else:473 else:

Subscribers

People subscribed via source and target branches

to all changes: