Merge lp:~brian-murray/arsenal/days-with-importance into lp:~bryce/arsenal/2.x

Proposed by Brian Murray
Status: Merged
Merged at revision: 1086
Proposed branch: lp:~brian-murray/arsenal/days-with-importance
Merge into: lp:~bryce/arsenal/2.x
Diff against target: 90 lines (+24/-0)
1 file modified
scripts/collect-bug-data (+24/-0)
To merge this branch: bzr merge lp:~brian-murray/arsenal/days-with-importance
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Review via email: mp+115216@code.launchpad.net

Description of the change

I discovered that you can't search on importance with collect-bug-data so I fixed that. I also added in searching for how long a bug has had it's importance set.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/collect-bug-data'
2--- scripts/collect-bug-data 2012-07-10 16:15:03 +0000
3+++ scripts/collect-bug-data 2012-07-16 19:55:22 +0000
4@@ -307,6 +307,12 @@
5 Dbg.verbose('search: status: \'%s\'\n' % ','.join(search_status))
6
7 try:
8+ search_importance = search_criteria['importance']
9+ except KeyError:
10+ search_importance = []
11+ Dbg.verbose('search: importance: \'%s\'\n' % ','.join(search_importance))
12+
13+ try:
14 search_order = search_criteria['order_by']
15 except KeyError:
16 search_order = '-datecreated'
17@@ -344,6 +350,11 @@
18 except KeyError:
19 statuslength = False
20
21+ try:
22+ implength = search_criteria['days-with-importance']
23+ except KeyError:
24+ implength = False
25+
26 # ensure that only one of these are selected
27 count = 0
28 if search_assignees != '':
29@@ -362,6 +373,7 @@
30 search_args = {'tags': search_tags,
31 'tags_combinator': search_tags_combinator,
32 'status': search_status,
33+ 'importance': search_importance,
34 'modified_since': last_run_time,
35 'order_by': search_order}
36
37@@ -376,6 +388,8 @@
38 tasks.set_filter_reopened()
39 if statuslength:
40 tasks.set_filter_status_length(statuslength)
41+ if implength:
42+ tasks.set_filter_status_length(implength)
43 reported_tasks.append(tasks)
44 else:
45 for participant in search_reporter.participants:
46@@ -387,6 +401,8 @@
47 tasks.set_filter_reopened()
48 if statuslength:
49 tasks.set_filter_status_length(statuslength)
50+ if implength:
51+ tasks.set_filter_status_length(implength)
52 for task in tasks:
53 reported_tasks.append(task)
54 if search_limit:
55@@ -404,6 +420,8 @@
56 tasks.set_filter_reopened()
57 if statuslength:
58 tasks.set_filter_status_length(statuslength)
59+ if implength:
60+ tasks.set_filter_status_length(implength)
61 assigned_tasks.append(tasks)
62 search_assignee_names.append(search_assignee.name)
63 else:
64@@ -416,6 +434,8 @@
65 tasks.set_filter_reopened()
66 if statuslength:
67 tasks.set_filter_status_length(statuslength)
68+ if implength:
69+ tasks.set_filter_status_length(implength)
70 for task in tasks:
71 assigned_tasks.append(task)
72 if search_limit:
73@@ -434,6 +454,8 @@
74 tasks.set_filter_reopened()
75 if statuslength:
76 tasks.set_filter_status_length(statuslength)
77+ if implength:
78+ tasks.set_filter_status_length(implength)
79 if search_limit:
80 return tasks[:search_limit]
81 else:
82@@ -444,6 +466,8 @@
83 tasks.set_filter_reopened()
84 if statuslength:
85 tasks.set_filter_status_length(statuslength)
86+ if implength:
87+ tasks.set_filter_status_length(implength)
88 if search_limit:
89 return tasks[:search_limit]
90 else:

Subscribers

People subscribed via source and target branches

to all changes: