Code review comment for lp:~brad-marshall/charms/trusty/nagios/add-livestatus-support

Revision history for this message
Adam Israel (aisrael) wrote :

Hi!

I'm doing a triage of reviews in the queue, in the spirit of fail-fast. This is a cursory check of the proposed merge to see if there are any "obvious" things that may prevent the review from being accepted.

The goal is to get you feedback sooner, before an in-depth review has been done. I'm happy to see the addition of a unit test for the new functionality. Could you also add something to the README to explains the usage of this new feature?

Thanks!

« Back to merge proposal