Code review comment for lp:~asanjar/charms/trusty/hdp-hadoop/trunk

Revision history for this message
Charles Butler (lazypower) wrote :

Amir - this merge has some great content however its not going to cleanly apply over the existing charm store branch.

I've got a fixup that took your changes and applied them over the charm store series - minus the whitespace changes and pushed it to bigdata-dev and will propose for bigdata-charmers.

https://code.launchpad.net/~bigdata-dev/charms/trusty/hdp-hadoop/trunk

Make sure you backport these changes into your personal namespace when doing future dev, otherwise you will have this problem again.

Thanks for the contribution!

review: Needs Fixing

« Back to merge proposal