Merge lp:~agronick/vocal/vocal into lp:vocal
Status: | Needs review | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp:~agronick/vocal/vocal | ||||||||
Merge into: | lp:vocal | ||||||||
Diff against target: |
448 lines (+114/-117) 4 files modified
CMakeLists.txt (+2/-1) src/Objects/Episode.vala (+7/-3) src/Utils/Player.vala (+103/-112) src/Widgets/EpisodeDetailBox.vala (+2/-1) |
||||||||
To merge this branch: | bzr merge lp:~agronick/vocal/vocal | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nathan Dyer | Pending | ||
Review via email: mp+261302@code.launchpad.net |
Description of the change
Vocal was crashing with a segmentation fault when playing certain videos. When I looked at the URL I found that it was doing a 302 redirect and setting the Location header. In Player.vala Gst.PbUtils.
Many podcasting services use redirects for analytics and tracking. All of the videos in this RSS feed will crash Vocal unless my code is used: http://
The new code also prevents Vocal from cashing if get_video_streams() returns an empty list for some other reason.
Unmerged revisions
- 299. By Kyle
-
New seek method makes the player a lot more responsive.
- 298. By Kyle
-
Turns out redirects were not the issue with the origional bug. The timeouts were too small. Removed redirect handling code. Kept code preventing segmentation faults. Increased timeouts.
- 297. By Kyle
-
Merging changes
- 296. By Kyle
-
Fixed segfault with certain podcasts
- 295. By Kyle
-
Fixed bug with redirecting URLs
I also fixed the bug that was causing the segfault with certain feeds. This was from accessing an array out of bounds in Eppisode.vala if the dates are not formatted correctly. After checking the length of the array it was displaying "(null)" where the dates are set to appear on the sidepane. I made it so it shows an empty string instead.