Merge lp:~adam-stokes/arsenal/arsenal into lp:arsenal/trunk

Proposed by Adam Stokes
Status: Merged
Merged at revision: 979
Proposed branch: lp:~adam-stokes/arsenal/arsenal
Merge into: lp:arsenal/trunk
Diff against target: 49 lines (+9/-4)
3 files modified
debian/changelog (+6/-0)
debian/rules (+1/-1)
setup.py (+2/-3)
To merge this branch: bzr merge lp:~adam-stokes/arsenal/arsenal
Reviewer Review Type Date Requested Status
Bryce Harrington code Approve
Review via email: mp+101568@code.launchpad.net

This proposal supersedes a proposal from 2012-04-11.

Description of the change

Fix path location to language helper class in cdbs
Fix scripts loading in python distutils setup.py

To post a comment you must log in.
Revision history for this message
Adam Stokes (adam-stokes) wrote : Posted in a previous version of this proposal

The changelog has a weird packaging entry wrt ~lucid|precise is it possible to agree on a certain naming scheme?

Revision history for this message
Bryce Harrington (bryce) wrote :

Changes look fine.

We don't actually ship arsenal in ubuntu (yet), but these look like sane updates to the packaging.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-08-15 15:40:00 +0000
+++ debian/changelog 2012-04-11 14:34:33 +0000
@@ -1,3 +1,9 @@
1arsenal (0.1.3~precise) precise; urgency=low
2
3 * Fix debian packaging issues
4
5 -- Adam Stokes <adam.stokes@canonical.com> Wed, 11 Apr 2012 10:08:22 -0400
6
1arsenal (0.1.3~lucid) lucid; urgency=low7arsenal (0.1.3~lucid) lucid; urgency=low
28
3 * Check launchpadlib version before appending beta to API url9 * Check launchpadlib version before appending beta to API url
410
=== modified file 'debian/rules' (properties changed: -x to +x)
--- debian/rules 2011-09-12 12:48:57 +0000
+++ debian/rules 2012-04-11 14:34:33 +0000
@@ -5,7 +5,7 @@
55
6include /usr/share/cdbs/1/rules/debhelper.mk6include /usr/share/cdbs/1/rules/debhelper.mk
7include /usr/share/cdbs/1/class/python-distutils.mk7include /usr/share/cdbs/1/class/python-distutils.mk
8include /usr/share/cdbs/1/rules/langpack.mk8include /usr/share/cdbs/1/class/langcore.mk
99
10DEB_DH_INSTALL_SOURCEDIR := debian/tmp10DEB_DH_INSTALL_SOURCEDIR := debian/tmp
11DEB_PYTHON_INSTALL_ARGS_ALL := --no-compile --install-scripts usr/share/arsenal --install-purelib=/usr/lib/python$(cdbs_python_current_version)/dist-packages/11DEB_PYTHON_INSTALL_ARGS_ALL := --no-compile --install-scripts usr/share/arsenal --install-purelib=/usr/lib/python$(cdbs_python_current_version)/dist-packages/
1212
=== modified file 'setup.py' (properties changed: -x to +x)
--- setup.py 2012-03-27 00:54:25 +0000
+++ setup.py 2012-04-11 14:34:33 +0000
@@ -1,6 +1,7 @@
1#!/usr/bin/python1#!/usr/bin/python
22
3from distutils.core import setup3from distutils.core import setup
4from arsenal import info
4import glob, os, re5import glob, os, re
56
6# look/set what version we have7# look/set what version we have
@@ -33,9 +34,7 @@
33 ('/var/lib/arsenal/templates', glob.glob('web/templates/*.*')),34 ('/var/lib/arsenal/templates', glob.glob('web/templates/*.*')),
34 ('/var/lib/arsenal/templates/frame', glob.glob('web/templates/frame/*.*')),35 ('/var/lib/arsenal/templates/frame', glob.glob('web/templates/frame/*.*')),
35 ],36 ],
36 scripts=[37 scripts=glob.glob('scripts/*'),
37 glob.glob('scripts/*'),
38 ],
39 )38 )
4039
41# Uninstallation:40# Uninstallation:

Subscribers

People subscribed via source and target branches

to status/vote changes: