FFe: Update mc to version 4.8.1

Bug #905610 reported by Kevin Williams
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mc (Debian)
Fix Released
Unknown
mc (Ubuntu)
Fix Released
Wishlist
Maarten Bezemer

Bug Description

Current upstream rev of MC is 4.8.1.1, while we're still shipping v4.7.0.9. Debian has not yet packaged this release and is still on basically the same release as Ubuntu.

Related branches

tags: added: upgrade-software-version
Changed in mc (Debian):
status: Unknown → New
Revision history for this message
Maarten Bezemer (veger) wrote :

I'll give it a try...

Changed in mc (Ubuntu):
status: New → In Progress
assignee: nobody → Maarten Bezemer (veger)
Revision history for this message
Maarten Bezemer (veger) wrote :

I have updated mc to version 4.8.1 from the upstream sources, as debian packages were outdated as well.
I do not use it very much, but after building it locally, it seems to work nicely.

Because this new version is much newer than the current one, the debdiff is humongous (~ 4MB with gzip) so I won't put it here (unless it is requested). So please us the branch/merge request to check out the differences

Maarten Bezemer (veger)
Changed in mc (Ubuntu):
status: In Progress → Confirmed
assignee: Maarten Bezemer (veger) → nobody
Maarten Bezemer (veger)
summary: - New upstream release
+ Update mc to version 4.8.1
Revision history for this message
Andreas Moog (ampelbein) wrote : Re: Update mc to version 4.8.1

This needs a FreezeException now that we are in Feature Freeze. See https://wiki.ubuntu.com/FreezeExceptionProcess#FeatureFreeze_for_new_upstream_versions how to request one.

Changed in mc (Ubuntu):
assignee: nobody → Maarten Bezemer (veger)
importance: Undecided → Wishlist
status: Confirmed → Incomplete
Revision history for this message
Maarten Bezemer (veger) wrote :

FeatureFeeze Exception request
~~~~~~~~~~~~~~~~~~~~~~~~~~

The reason:
- mc is very outdated and lots of bugs have been fixed between 4.7.0.9 and 4.8.1
- On LP these bugs are fixed by the update: Bug #314614, Bug #410031, Bug #562361, Bug #632816, Bug #713630, Bug #770673 and Bug #837163. I confirmed all of these bugs with the current version 4.7.0.9 and saw that are fixed with version 4.8.1

Notes on the attached files:
- changelog.diff it seems that they changed version numbers, the changes of 4.7.0.x are very similar the same as the ones in 4.7.4 (in the 4.8.1 NEW document). So the changelog.diff is not a 'real' diff.
- mc-4.8.1-build.log is the log for building for Precise (but it builds perfectly fine with Oneiric as well)

Performed tests:
I have tested all mc related bugs, with both the current version and 4.8.1. Not all bugs are fixed, the non-fixed bugs I could confirm. So I have tried quite some different parts of mc 4.8.1 and everything worked as expected.

Additional notes:
I will put mc-4.8.1(exactly the same as the one in the build log) in my personal PPA for easy testing.

Revision history for this message
Maarten Bezemer (veger) wrote :
Revision history for this message
Maarten Bezemer (veger) wrote :
Maarten Bezemer (veger)
Changed in mc (Ubuntu):
assignee: Maarten Bezemer (veger) → nobody
status: Incomplete → Confirmed
Andreas Moog (ampelbein)
summary: - Update mc to version 4.8.1
+ FFe: Update mc to version 4.8.1
Revision history for this message
Stefano Rivera (stefanor) wrote :

This seems reasonable, however:
* It's not a sync from Debian, so it has had less eyeballs and testing. Please subscribe yourself to mc's bugs (for at least a couple of months).
* I see that Debian's mc team is subscribed to Ubuntu bug mail, but they seem rather inactive at the moment. So please forward this packaging to them.
* The update removes the /etc/mc/Syntax directory. Is that no longer checked by mc? What about existing syntax rules in it?

I can't grant an FFe without an answer to the last question.

Revision history for this message
Maarten Bezemer (veger) wrote :

/etc/mc/Syntax is moved to /usr/share/mc/Syntax, see Changelog of version 4.7.5-pre1:
* Changed installation destination for some files (#1424):
        - /etc/mc/Syntax -> /usr/share/mc/syntax/Syntax;
        - /etc/mc/mc.lib -> /usr/share/mc/mc.lib;
        - /etc/mc/mc.charsets -> /usr/share/mc/mc.charsets. Added capability to load codepage list
          from /usr/share/mc/mc.charsets and /etc/mc/mc.charsets and merge them then;
        - hint files are installed into /usr/share/mc/hints instead of /usr/share/mc;
        - help files are installed into /usr/share/mc/help instead of /usr/share/mc.

Furthermore, I'll subscribe myself to the mc's bugs (when I found out how to do so).
And about forwarding to package, should I wait until it gets approved here, so eventual changes are applied and they receive a complete package?

Revision history for this message
Maarten Bezemer (veger) wrote :

BTW, the mc packages in my ppa (https://launchpad.net/~veger/+archive/ppa) are finished building for Precise and Oneiric.

Revision history for this message
Stefano Rivera (stefanor) wrote :

err /etc/mc/Syntax was a file not a directory. Going from the source and Debian bug #539917, it looks like /usr/share is the correct place for it, it'll be overridden by /etc/mc/Syntax, should that exist.

However, /etc/mc/Syntax was a conffile and the new package won't include it, so it'll remain installed, overriding the one in /usr/share/mc, even if it's never been modified. That's probably not ideal. Please look at dpkg-maintscript-helper as a sane way to remove it.

Given the activity in the mc team in Debian, there won't be time to get them to upload this before Beta 1, so forwarding the patch doesn't need to come first.

Revision history for this message
Maarten Bezemer (veger) wrote :

Sorry, it took so long (see bug #936340), but I finally managed to use dpkg-maintscript-helper (was using the wrong version format)
I also noticed that /etc/mc/cedit.menu is renamed to etc/mc/mcedit.menu so I will fix this a well and check the other conffiles as well before uploading a new version

Revision history for this message
Maarten Bezemer (veger) wrote :

The following changes are made:
- These obsolete /etc/mc/ files are now removed: Syntax, mc.charsets and mc.lib files, the default these are all moved to /usr/share/mc to override these defaults appropriate files can be added to /etc/mc by the user
- /etc/mc/cedit.menu is renamed to /etc/mc/mcedit.menu

I'll update the packages in my PPA as well

Revision history for this message
Stefano Rivera (stefanor) wrote :

We don't want to use the "supports" check, but rather a Pre-Depends, see the bugs cjwatson has been filing in Debian, like this one: http://bugs.debian.org/659765

Revision history for this message
Maarten Bezemer (veger) wrote :

Ok, I'll change it. I read in the man page that it was the desired way if the operation is not critical for the package (which I thought is the case here):
  "But in many cases the operation done by the program is not critical for the package, and instead of using a pre-dependency we can call the program only if we know that the required command is supported by the currently installed dpkg"

Revision history for this message
Stefano Rivera (stefanor) wrote :

Yes, that'll be an issue for upgrades from Lucid

Revision history for this message
Maarten Bezemer (veger) wrote :

It is updated (again not debdiff due to the size)

Changed in mc (Debian):
status: New → Fix Released
Revision history for this message
Stefano Rivera (stefanor) wrote :

We've picked up the Debian upload, but it can't be synced without modification. It's missing a Pre-Depends for dpkg-maintscript-helper.

Revision history for this message
Stefano Rivera (stefanor) wrote :

FFe granted. Please do this before Beta 2.

Whoever syncs this, please add a Pre-Depends on dpkg-maintscript-helper. The Debian maintainers don't seem to want to do that.

Changed in mc (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Maarten Bezemer (veger) wrote :

I'll see to sync this package using debian version 4.8.1-2

Changed in mc (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Maarten Bezemer (veger)
Revision history for this message
Maarten Bezemer (veger) wrote :

I have synced mc, except for the Pre-Depends change, I did not change anything else after the sync to make it work. See ubuntu-changes-v2.patch for the complete changes please take a look at lp:~veger/ubuntu/precise/mc/fix-for-905610-v2

The package has been uploaded my ppa (https://launchpad.net/~veger/+archive/ppa) as well, for testing purposes

Revision history for this message
Maarten Bezemer (veger) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.4 KiB)

This bug was fixed in the package mc - 3:4.8.1-2ubuntu1

---------------
mc (3:4.8.1-2ubuntu1) precise; urgency=low

  * Sync from debian testing (LP: #905610, LP: #314614, LP: #410031,
      LP: #562361, LP: #632816, LP: #713630, LP: #770673, LP: #837163)
  * Added Pre-Depends for dpkg-maintscript-helper availability

mc (3:4.8.1-2) unstable; urgency=low

  * Build-Depends are updated: 'bison' moved to build-deps;
    architecture wildcard replaced silly "type-handling | not+linux-gnu"
    (Closes: #587875 N:"Please remove type-handling dependency")
  * new patch to increase maximum file size for mcedit to 128 MiB
    (Closes: #369565 W:"mcedit: wishing a bigger file size limit")
    Thanks to Daniele Giacomini.
  * new patch to disable "Return does autoindent" by default in mcedit
    (Closes: #570502 N:"mcedit: adding extra spaces when pasting a text
     preceded by spaces")
    (Closes: #575711 N:"pasting extra tabs, AGAIN")
  * added mc.NEWS file with notes about important changes in this release
    (Closes: #661435 W:"lynx-like motion is lost during upgrade to 4.8.1")
  * added symlinks to all scripts in /usr/lib/mc for backward compatibility
  * new patch to correct path to scripts in man page
    (Closes: #661481 N:"Acknowledgement mc: /usr/share/mc/bin/mc.sh missing")
  * 'unzip' added to build-deps to set proper zip mode at build-time;
    'unzip' moved to Recommends from Suggests.
    (Closes: #661467 N:"mc: zip file browsing broken")
  * Recommends 'perl' and 'unzip' instead of Suggests
  * dropped old 20_wrong_path_to_wrappers.patch, which was breaking
    correct path to wrappers (note the precisely chosen file name ;)
  * corrected and properly annotated 09_uzip_broken_528239.patch

mc (3:4.8.1-1) unstable; urgency=low

  * New upstream release [December 2011]
    (Closes: #618542 N:"please follow upstream progress")
    (Closes: #528331 N:"[VFS] utar is unable to open .tar files")
    (Closes: #626287 N:"SHIFT+F6 should open rename dialog")
    (Closes: #609489 I:"If <F4> is pressed ~/.mc/cedit/Syntax is missing")
    (Closes: #606331 I:"regression: panel configuration on startup;
     view search configuration")
    (Closes: #567119 I:"mcedit ignores editnormal in MC_COLOR_TABLE")
    (Closes: #587372 N:"fish does not preserve modification time when
     copying files to remote host")
    (Closes: #592396 N:"file rename (F6) with non-usual characters failed")
    (Closes: #525146 N:"mc hangs when copying multiple files from ftp")
    (Closes: #574761 N:" [VFS] internal tar considers files containig
     '@' as directories.")
    (Closes: #584687 N:"mc/fish segfaults when remote copy/move appends
     to existing file")
    (Closes: #619092 W:"Wishlist: mc to open ISO files")
    (Closes: #602857 M:"use 7zr for generic .7z archives if available")
    (Closes: #61987 W:"total ETA wanted")
  * debian/watch
    • fixed and updated to fetch latest .tar.xz
  * dropped CDBS, now using debhelper only
  * debhelper & compat to version 9
  * dh-autoreconf to update toolchain
  * intltoolize to refresh Makefile.in.in
  * debian/control
    • standards to 3.9.3 (thanks to Andreas Tille)
    • added to build-deps:
      + 'type-handling...

Read more...

Changed in mc (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.