Awn

Every option in the awn-manager should change the awn-bar instantly

Bug #236523 reported by black
2
Affects Status Importance Assigned to Milestone
Awn
Fix Released
High
black
Awn 0.2.8

Bug Description

Mainly that is implemented everywhere. If you switch to rounded corners, awn does it instantly. Though there are several options that doesn't act like that.
- Bar Apppearance -> 'Show separator between launchers and tasks' (fix commited)
- Pattern Engine -> 'Enable pattern' (fix commited)
- Pattern Engine -> 'Transparency' (fix commited)
- Task Appearance -> 'Tasks have arrows' (fix commited)
- Task Appearance -> 'Arrow offset' (fix commited)
- Bar Appearance -> 'look' (fix commited)

branch: 0.2
revision: 199

See original description
Mark Lee (malept)
Changed in awn:
importance: Undecided → High
milestone: none → 0.2.8
status: New → Confirmed
Revision history for this message
black (blackborn) wrote :

For the options above, this is a patch against r262 of the trunk.

Changed in awn:
status: Confirmed → In Progress
Revision history for this message
moonbeam (rcryderman) wrote :

Patch committed. Rev 263. Thanks.

Changed in awn:
status: In Progress → Fix Committed
black (blackborn)
description: updated
Changed in awn:
status: Fix Committed → In Progress
Revision history for this message
black (blackborn) wrote :

I haven't enough knowledge to add the g_signal_connect for 'Tasks have arrows' and 'Arrow offset'

You cannot use the bar_refresh function of the main.c, because it doesn't repaint the arrows.
You can try to add a signal connect that calls something like _refresh_box in the awn-task-manager.c. That should do it.

Revision history for this message
black (blackborn) wrote :

I found a clue while doing bug 240716 and here is the patch

description: updated
Revision history for this message
moonbeam (rcryderman) wrote :

Pushed the 2nd patch. http://bazaar.launchpad.net/~awn-core/awn/trunk/revision/306.

Thanks.

Changed in awn:
status: In Progress → Fix Committed
black (blackborn)
description: updated
Changed in awn:
assignee: nobody → blackborn
Revision history for this message
black (blackborn) wrote :

Find another option.
If the look is changed, the bar only redraws himself.
Though the icons also need to be redrawn. (The 3px width of the bar has to be calculated)

patch against r306 of trunk

description: updated
black (blackborn)
Changed in awn:
status: Fix Committed → In Progress
Revision history for this message
moonbeam (rcryderman) wrote :

I'll look at this tomorrow assuming someone else doesn't :-)

As a side note I'd appreciate if you could open a new bug for patches which deal with a different specific issue. It'll make it easier for those who accumulate lists of fixes and such at release time.

Thanks.

Revision history for this message
moonbeam (rcryderman) wrote :

Applied the third patch. rev 309. This seems to make the resize noisier (bar shifts around a lot and I'm seeing flashes of white lines / blocks) but I'm inclined to think that is better than not having the update applied correctly. The white/bar issue is something that is more fundamental anyway... once that gets cleaned up the "noise" will be better.

moonbeam (rcryderman)
Changed in awn:
status: In Progress → Fix Committed
Revision history for this message
moonbeam (rcryderman) wrote :

Correct revision number is 310

black (blackborn)
description: updated
moonbeam (rcryderman)
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.