[SRU] Can't set a list of forwarders (BIND config)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Raphaël Badin | ||
1.8 |
Fix Released
|
Critical
|
Raphaël Badin | ||
maas (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned | ||
Utopic |
Won't Fix
|
Undecided
|
Unassigned | ||
Vivid |
Fix Released
|
Undecided
|
Unassigned | ||
Wily |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The MAAS UI and the MAAS API only allow the user to pass a single address for the `forwarders` config. Note that the backend already support a space separated list of IPs.
[Impact]
This issue prevents users from adding multiple DNS resolvers in MAAS. With the fix, the user can add multiple DNS resolvers for MAAS to manage.
[Test Case]
Without the fix:
1. Install maas (sudo apt-get install maas)
2. Go to the Settings page on the Web UI
3. Go to the DNS settings and Add multiple DNS servers as forwarders
4. MAAS will fail to add multiple DNS servers as forwarders
With the fix:
1. Install maas (sudo apt-get install maas)
2. Go to the Settings page on the Web UI
3. Go to the DNS settings and Add multiple DNS servers as forwarders
4. MAAS will add multiple DNS servers as forwarders
[Regression Potential]
Minimal. This has been tested extensively in various environments, both on fresh installs and upgrades.
Related branches
- Mike Pontillo (community): Approve
-
Diff: 176 lines (+77/-6)5 files modifiedsrc/maasserver/dns/tests/test_config.py (+4/-3)
src/maasserver/fields.py (+25/-1)
src/maasserver/forms_settings.py (+3/-2)
src/maasserver/tests/test_fields.py (+37/-0)
src/maasserver/tests/test_forms_settings.py (+8/-0)
- Gavin Panella (community): Approve
-
Diff: 295 lines (+124/-13)9 files modifiedetc/maas/templates/dns/named.conf.options.inside.maas.template (+5/-3)
src/maasserver/dns/config.py (+10/-1)
src/maasserver/dns/tests/test_config.py (+23/-3)
src/maasserver/fields.py (+25/-1)
src/maasserver/forms_settings.py (+3/-2)
src/maasserver/tests/test_fields.py (+37/-0)
src/maasserver/tests/test_forms_settings.py (+8/-0)
src/maastesting/factory.py (+6/-0)
src/provisioningserver/dns/tests/test_config.py (+7/-3)
- Gavin Panella (community): Approve
-
Diff: 196 lines (+81/-9)5 files modifiedsrc/maasserver/dns/tests/test_config.py (+8/-6)
src/maasserver/fields.py (+25/-1)
src/maasserver/forms_settings.py (+3/-2)
src/maasserver/tests/test_fields.py (+37/-0)
src/maasserver/tests/test_forms_settings.py (+8/-0)
- Mike Pontillo (community): Approve
-
Diff: 81 lines (+29/-10)3 files modifieddebian/changelog (+11/-1)
debian/maas-dns.postinst (+7/-9)
debian/maas-region-controller.postinst (+11/-0)
Changed in maas: | |
importance: | High → Critical |
Changed in maas: | |
assignee: | nobody → Raphaël Badin (rvb) |
status: | Triaged → Fix Committed |
milestone: | none → 1.9.0 |
summary: |
- Can't set a list of forwarders (BIND config) + [SRU] Can't set a list of forwarders (BIND config) |
description: | updated |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas (Ubuntu Utopic): | |
status: | New → Won't Fix |
Note that the template on 1.7 looks like it only supports a single forwarder. It was fixed for 1.8 as a part of this merge:
https:/ /code.launchpad .net/~allenap/ maas/celery- in-dns- removal/ +merge/ 241852