Symbols & and ? in the name of a large object

Looks like I can't read your patch because of the name (launchpad returns error 400).

Can you rename the patch?

Yes, of course. I've renamed it. Now it is readed.

Any hope this issue will be resolved in the reasonable time? It's a deal breaker for us. We can't transfer our old data because of this.

Bad Request for ? and & was added in
https://github.com/openstack/swift/commit/fa3c871f0b1544f859bacf38497580afd69ced0b

so gholt should probably chime in, before proposed patch is considered.

Swift header values should be url encoded (so you can include newlines and such).

However, there is a bug where the x-object-manifest header isn't unquoted after splitting; around line 915 of the proxy/server.py at the moment:

        if 'x-object-manifest' in resp.headers:
            lcontainer, lprefix = \
                resp.headers['x-object-manifest'].split('/', 1)
            try:
                listing = list(self._listing_iter(lcontainer, lprefix,
                                req.environ))

etc.

I'll try to fix that up soon with a unit test for it; but if I don't get to it before someone else, I won't complain. :)

Oh, and I guess this bug (or a duplicate spawned, however it's done) should be for python-swiftclient too, where it needs to url encode the header value.

Fix proposed to branch: master
Review: https://review.openstack.org/9149

The companion fix to bin/swift is at https://review.openstack.org/#/c/9151/

With both fixes in place:

$ ls -l "4&4.txt"
-rw-r--r-- 1 gholt gholt 140 2012-06-28 23:40 4&4.txt

$ swift upload -S 10 2 "4&4.txt"
4&4.txt segment 0
4&4.txt segment 7
4&4.txt segment 6
4&4.txt segment 1
4&4.txt segment 8
4&4.txt segment 5
4&4.txt segment 9
4&4.txt segment 4
4&4.txt segment 2
4&4.txt segment 3
4&4.txt segment 13
4&4.txt segment 12
4&4.txt segment 11
4&4.txt segment 10
4&4.txt

$ swift list 2
4&4.txt

$ swift list 2_segments
4&4.txt/1340926847.0/140/00000000
4&4.txt/1340926847.0/140/00000001
4&4.txt/1340926847.0/140/00000002
4&4.txt/1340926847.0/140/00000003
4&4.txt/1340926847.0/140/00000004
4&4.txt/1340926847.0/140/00000005
4&4.txt/1340926847.0/140/00000006
4&4.txt/1340926847.0/140/00000007
4&4.txt/1340926847.0/140/00000008
4&4.txt/1340926847.0/140/00000009
4&4.txt/1340926847.0/140/00000010
4&4.txt/1340926847.0/140/00000011
4&4.txt/1340926847.0/140/00000012
4&4.txt/1340926847.0/140/00000013

$ swift stat 2 "4&4.txt"
       Account: AUTH_test
     Container: 2
        Object: 4&4.txt
  Content Type: text/plain
Content Length: 140
 Last Modified: Thu, 28 Jun 2012 23:45:40 GMT
          ETag: "98ac91c9c31bd2f7b12678f3c637cc19"
      Manifest: 2_segments/4%264.txt/1340926847.0/140/
    Meta Mtime: 1340926847.0
 Accept-Ranges: bytes
   X-Timestamp: 1340927140.38237

$ mv "4&4.txt" orig.txt

$ swift download 2 "4&4.txt"
4&4.txt

$ diff orig.txt "4&4.txt"

FYI: Greg has been working on this in https://review.openstack.org/#/c/9151/

Chmouel, indeed I have. Please see my comments above. :P

To reiterate, the two patches required to fix this bug are:

https://review.openstack.org/9149
https://review.openstack.org/#/c/9151/

Reviewed: https://review.openstack.org/9149
Committed: http://github.com/openstack/swift/commit/f2a61ab50ed755b0a3c8bf57bf6795d25ff47851
Submitter: Jenkins
Branch: master

commit f2a61ab50ed755b0a3c8bf57bf6795d25ff47851
Author: gholt <email address hidden>
Date: Thu Jun 28 23:25:27 2012 +0000

    Fixed bug 1011636 with segmented objects

    The X-Object-Manifest header value should be url encoded to allow for
    "special" characters to be used. This fix decodes such encoding. A
    corresponding fix to python-swiftclient (and any other clients) needs
    to be made to url encode the header value when sending.

    I also fixed any pep8 1.3.1 violations I found in the test I modified
    to verify this.

    Change-Id: I67f23dec1dc95ee37354dfdd9897f34758135ee6

ttx: This affects both swift and swiftclient. I couldn't make a sibling bug on swiftclient before, but now that we can should we instead do that?

karpov (ikarpov-9): Did you get to try this out to resolve your immediate issues?

gholt : yes it fix the problem, thanks a lot

The attachment "Fix problem with ampersend and question mark in the name of a large object.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]