Code review comment for lp:~qos/do-plugins/ssh-browse-via-sftp

Revision history for this message
Alex Launi (alexlauni) wrote :

1) Please return the localizer to the autofoo one. You've hardcoded the path in the Addin.xml.in.
2) SSHActionSFTP is an ugly name, StfpAction.cs.
3) You've got a bunch of Mono guideline violations, make sure that all of your method calls have a space between the method name and the parameters. Method (param);
4) You dont need SupportsItem if you're just returning True, that's what the parent method does.
5) I don't like that you've got the code for finding the file manager in two places. You should make a new static class Util.cs that has a static method FindFileManager () that will search GConf for the file manager, then you're not copying and pasting blocks. Much cleaner.

review: Needs Fixing

« Back to merge proposal