Code review comment for lp:~marvil07/do-plugins/GNOME-Calculator

Revision history for this message
marvil07 (marvil07) wrote :

Hi Chris,

Thanks for the review!

Originally, when I write GNOME-Calculator Alex suggest me to make a regex filter for it.

This patch is a simple solution to avoid having a regex(I tried it, but it's hard[1] I think) to filter the input.

Also, IIRC this is also a solution in other software that do the same, so why not follow a good desition :-)

[1] http://git.gnome.org/cgit/gcalctool/tree/src/mp-equation-parser.y

review: Needs Information (answering)

« Back to merge proposal