Code review comment for lp:~iwarford/do-plugins/inline-google-fix
Revision history for this message
| Ian Warford (iwarford) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Wed, Dec 31, 2008 at 11:21 AM, Alex Launi <email address hidden> wrote:
> Review: Needs Fixing
> for IEnumerable<Type> SupportedItemTypes, instead of returning an array, use the yield keyword.
> With the new API you don't need ModifierItemsOp
>
> I would think about changing the array to an IEnumerable in GoogleSearch.Search
>
> Why was the search action's name changed from "search google" => "google search"? the first makes more sense for an action.
Bug 261295, IIRC. All of the Google-related plugins start with the
world Google *except* the search one. Ordering in the plugins pane
was considered more important than semantics.
> A bunch of calls in perform do not have spaces between the call and the paren. This is also true in the config
I'll see if I get a chance to get the rest of the stuff done tonight.
If not, I have tomorrow off.