Code review comment for lp:~iwarford/do-plugins/inline-google-fix

Revision history for this message
Alex Launi (alexlauni) wrote :

for IEnumerable<Type> SupportedItemTypes, instead of returning an array, use the yield keyword.
With the new API you don't need ModifierItemsOptional

I would think about changing the array to an IEnumerable in GoogleSearch.Search

Why was the search action's name changed from "search google" => "google search"? the first makes more sense for an action.

A bunch of calls in perform do not have spaces between the call and the paren. This is also true in the config

review: Needs Fixing

« Back to merge proposal