Code review comment for lp:~zyga/testtools/use-versiontools

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

> I'm not really a testtools reviewer, but involved in the packaging. Some
> issues I noticed:

Hi, thanks for your review!

> This removes the distinction for version phases ("final", "alpha", etc) and
> causes the version number to be 0.9.14 for all snapshots following release
> 0.9.14, rather than snapshot-0.9.14. This in particular matters for recipe
> builds, where we create a source package without the .bzr directory.

versiontools handles this case correctly. The snapshot, created with sdist, will have proper revision information along with it (in the PKG-INFO file). Versiontools will fetch it. As for alphas, betas and more: this is supported but the __version__ needs accurately convey this information. See: http://versiontools.readthedocs.org/en/latest/#how-version-tuple-affects-version-string

> It looks like versiontools isn't packaged for Debian or Ubuntu yet. It would
> be nice if that could happen before testtools starts depending on it,
> otherwise we can't upload newer versions to Debian/Ubuntu.

There is a package but I've never pushed it to Ubuntu. I'll see what I can do about that.

« Back to merge proposal