Merge lp:~zyga/snapcraft/fix-logging-setup into lp:~snappy-dev/snapcraft/core

Proposed by Zygmunt Krynicki on 2015-08-26
Status: Merged
Approved by: Michael Vogt on 2015-08-26
Approved revision: no longer in the source branch.
Merged at revision: 135
Proposed branch: lp:~zyga/snapcraft/fix-logging-setup
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 12 lines (+1/-1)
1 file modified
snapcraft/log.py (+1/-1)
To merge this branch: bzr merge lp:~zyga/snapcraft/fix-logging-setup
Reviewer Review Type Date Requested Status
Michael Vogt 2015-08-26 Approve on 2015-08-26
Review via email: mp+269163@code.launchpad.net

Commit Message

Correct logging setup

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Nice catch, thanks!

review: Approve
lp:~zyga/snapcraft/fix-logging-setup updated on 2015-08-26
135. By Zygmunt Krynicki on 2015-08-26

Correct logging setup by zyga approved by mvo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snapcraft/log.py'
2--- snapcraft/log.py 2015-07-30 14:45:01 +0000
3+++ snapcraft/log.py 2015-08-26 08:27:43 +0000
4@@ -43,7 +43,7 @@
5 handlers = [stdout_handler, stderr_handler]
6
7 formatter = logging.Formatter(
8- _COLOR_BOLD + '{msg}' + _COLOR_END, style='{')
9+ _COLOR_BOLD + '{message}' + _COLOR_END, style='{')
10 logger = logging.getLogger(logger_name)
11 for handler in handlers:
12 handler.setFormatter(formatter)

Subscribers

People subscribed via source and target branches