Merge lp:~zyga/linaro-android-build-tools/fix-997942 into lp:linaro-android-build-tools

[Zygmunt Krynicki]

This branch changes the toolchain used to cross build android. Our current
instructions ask the user to use gcc-4.5. Those instrucitons seem to fail on
12.04. As per bug 997942 and 1011992 I'd like to simply use the host toolchain
instead.

[Paul Sokolovsky (pfalcon)]

Looking at the patch and mentioned bugs, it seems that it's another case of ambiguity of what linaro_android_build_cmds.sh should be. The original idea was that we want to provide script which will reproduce exact release build as provided by us. To reproduce build exactly, we need to use the same tools and overall environment as our build systems does, it currently uses gcc-4.5, so this script would need to use too.

It seems that original idea above in the meantime transformed into "linaro_android_build_cmds.sh should build something". That may be well valid, but should be checked by stakeholder folks for this script - doanac (as the original author), pfefferz, asac.

So, the change syntactically valid, but semantics needs to be verified by someone else.

[Zygmunt Krynicki (zyga)]

I understand the intent but the fact is that those instructions don't currently work. If the goal is to keep building with 4.5 then we need to adjust the script to install proper packages and that list must depend on the version of the operating system the user is currently running.

[Alexander Sack (asac)]

we want to support lucid and precise without any host compiler flag tweakage. AFAIK it should work without that, so the instructions probably should also omit this. What we should do though is also set up a ci job that will test both build configurations for one job using the official instruction code we ship automatically. not today, but surely worth keeping in mind.

[Zygmunt Krynicki (zyga)]

asac: that would give different results for different versions of ubuntu. This is something that this patch would actually do. The question is: is that correct or should we use a fixed / prebuilt toolchain for all versions.

[Andy Doan (doanac)]

I think asac just +1 approved changed?

[Zygmunt Krynicki (zyga)]

> I think asac just +1 approved changed?

I didn't see any +1 here

[Paul Sokolovsky (pfalcon)]

Ok, there doesn't seem to be concerns expressed, vice-versa, calls to propagate changes in this patch (getting rid of gcc 4.5, etc) to android-build. Zygmunt, would you be interested to file bug ticket(s) for this and maybe work on that - as someone with fresh look, you would be in good position to improve old stuff (and mess) ;-).

Otherwise, approved.

review: Approve

=== modified file 'build-scripts/create-user-build-script'
--- build-scripts/create-user-build-script	2012-04-10 03:24:42 +0000
+++ build-scripts/create-user-build-script	2012-06-14 10:33:22 +0000
@@ -52,7 +52,7 @@
         esac
 done
 
-PKGS='zip curl flex bison build-essential git-core gnupg gperf zlib1g-dev libx11-dev x11proto-core-dev gcc-multilib g++-multilib libc6-dev-i386 ia32-libs lib32z-dev gcc-4.5 g++-4.5 cpp-4.5 gcc-4.5-multilib g++-4.5-multilib uboot-mkimage uuid-dev openjdk-6-jdk ant lib32ncurses5-dev'
+PKGS='zip curl flex bison build-essential git-core gnupg gperf zlib1g-dev libx11-dev x11proto-core-dev gcc-multilib g++-multilib libc6-dev-i386 ia32-libs lib32z-dev uboot-mkimage uuid-dev openjdk-6-jdk ant lib32ncurses5-dev'
 MISSING=\`dpkg-query -W -f='\${Status}\n' \${PKGS} 2>&1 | grep 'No packages found matching' | cut -d' ' -f5\`
 if [ -n "\$MISSING" ] ; then
 	echo "Missing required packages:"
@@ -175,7 +175,7 @@
 	cat <<EOF
 # build the code
 . build/envsetup.sh
-make -j\${CPUS} HOST_CC=gcc-4.5 HOST_CXX=g++-4.5 HOST_CPP=cpp-4.5 boottarball systemtarball userdatatarball
+make -j\${CPUS} boottarball systemtarball userdatatarball
 EOF
 }