Merge lp:~zyga/lava-dispatcher/preassign-uuids into lp:lava-dispatcher

[Zygmunt Krynicki]

This branch changes how uuids for test runs are generated. Instead of depending
on lava-test on a test device (which can have unreliable real time clock and
mac address) those ids are generated and provided by the dispatcher.

[Andy Doan (doanac)]

+1

review: Approve

Unmerged revisions

320. By Zygmunt Krynicki on 2012-06-07

Pre-assign analyzer_assigned_uuid from the dispatcher to work around unreliable
clock and mac address on a test device.

319. By Zygmunt Krynicki on 2012-06-07

Separate parts of the command that is used to start lava-test run for easier
manipulation.

=== modified file 'doc/changes.rst'
--- doc/changes.rst	2012-06-07 05:31:04 +0000
+++ doc/changes.rst	2012-06-07 08:39:20 +0000
@@ -8,6 +8,11 @@
 
 * Unreleased.
 
+* Pre-assign ``analyzer_assigned_uuid`` for the tests that are invoked on the
+  device. This way we don't depend on potentially unreliable timestamp and mac
+  address on the test device. This fixes launchpad bug
+  https://bugs.launchpad.net/lava-dispatcher/+bug/934164
+
 .. _version_0_12:
 
 Version 0.12

=== modified file 'lava_dispatcher/actions/lava-test.py'
--- lava_dispatcher/actions/lava-test.py	2012-05-23 04:03:59 +0000
+++ lava_dispatcher/actions/lava-test.py	2012-06-07 08:39:20 +0000
@@ -21,6 +21,7 @@
 # with this program; if not, see <http://www.gnu.org/licenses>.
 
 import logging
+import uuid
 
 from lava_dispatcher.actions import BaseAction
 from lava_dispatcher.client.base import OperationFailed
@@ -77,12 +78,15 @@
             session.run('mkdir -p %s' % self.context.lava_result_dir)
             session.export_display()
             bundle_name = generate_bundle_file_name(test_name)
+            cmd = [
+                'lava-test', 'run', test_name,
+                '-o', "{0}/{1}".format(self.context.lava_result_dir, bundle_name),
+                '--analyzer-assigned-uuid={0}'.format(uuid.uuid1()),
+            ]
             if test_options != "":
-                test_options = "-t '%s'" % test_options
-
-            cmd = ('lava-test run %s %s -o %s/%s.bundle' % (
-                    test_name, test_options, self.context.lava_result_dir,
-                     bundle_name))
+                # FIXME: proper shell quoting for test_options
+                cmd += ['-t', "'%s'" % test_options]
+            cmd = ' '.join(cmd)
             try:
                 rc = session.run(cmd, timeout=timeout)
             except: