LAVA Dashboard Tool

Merge lp:~zyga/lava-dashboard-tool/fix-query-data-view-args into lp:lava-dashboard-tool/linaro-11.05

  1. fix-query-data-view-args
  2. Merge into linaro-11.05
Proposed by Zygmunt Krynicki
Status: Merged
Merged at revision: 137
Proposed branch: lp:~zyga/lava-dashboard-tool/fix-query-data-view-args
Merge into: lp:lava-dashboard-tool/linaro-11.05
Diff against target: 27 lines (+12/-5)
1 file modified
launch_control_tool/commands/dashboard.py (+12/-5)
To merge this branch: bzr merge lp:~zyga/lava-dashboard-tool/fix-query-data-view-args
Reviewer Review Type Date Requested Status
Zygmunt Krynicki Pending
Review via email: mp+59485@code.launchpad.net

Description of the change

This fix makes query-data-view arguments without defaults required

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launch_control_tool/commands/dashboard.py'
2--- launch_control_tool/commands/dashboard.py 2011-04-29 00:20:42 +0000
3+++ launch_control_tool/commands/dashboard.py 2011-04-29 10:28:28 +0000
4@@ -833,11 +833,18 @@
5 data_view_parser.set_defaults(data_view=data_view)
6 group = data_view_parser.add_argument_group("Data view parameters")
7 for argument in data_view["arguments"]:
8- group.add_argument(
9- "--{name}".format(name=argument["name"]),
10- help=argument["help"],
11- type=str,
12- default=argument["default"])
13+ if argument["default"] is None:
14+ group.add_argument(
15+ "--{name}".format(name=argument["name"]),
16+ help=argument["help"],
17+ type=str,
18+ required=True)
19+ else:
20+ group.add_argument(
21+ "--{name}".format(name=argument["name"]),
22+ help=argument["help"],
23+ type=str,
24+ default=argument["default"])
25 self.args = self.parser.parse_args(raw_args)
26
27 def invoke_remote(self):

Subscribers

People subscribed via source and target branches

to all changes: