lp:~zyga/checkbox/sa-api-changes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 4073

Maciej Kisielewski: Approve on 2015-10-28

Sylvain Pineau: Approve on 2015-10-13

Diff: 127 lines (+69/-3)

3 files modified

plainbox/plainbox/impl/ingredients.py (+42/-1)
plainbox/plainbox/impl/session/assistant.py (+22/-1)
plainbox/plainbox/impl/session/test_assistant.py (+5/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

4073. By Zygmunt Krynicki on 2015-10-28

plainbox:ingredients: initialize SA with app meta-data

This patch makes CanonicalCommand initialize the internal
SessionAssistant object with application version and API version and
feature flags, as declared by the command.

Signed-off-by: Zygmunt Krynicki <email address hidden>

4072. By Zygmunt Krynicki on 2015-10-28

plainbox:ingredients: add get_sa_api_{version,flags} to CanonicalCommand

This patch allows CanonicalCommand consumers to define the expected
SessionAssistant API and feature flags with simple class-level
attributes. Two new getter methods are used to read them and provide
sensible defaults.

Signed-off-by: Zygmunt Krynicki <email address hidden>

4071. By Zygmunt Krynicki on 2015-10-28

plainbox: expand SessionAssistant initializer API

This patch modifies the session assistant initializer to allow up to
four arguments. The three new arguments are:

app_version: so that we can use this implicitly in some places,
 e.g. don't resumes sessions created by future versions, etc.
api_version: so that we can change usage expectations over time
 but let applications stay compatible by using a fixed API version.
 This can be changed to a __new__ call that returns a versioned
 SA class instead of doing if-then-else magic in all the places.
api_flags: so that we can allow applications to opt-into optional
 features and so that we can adjust expectations accordingly. This
 will also allow us to easily compare applications for feature
 parity.

For now all new arguments have sane defaults. Once all applications are
patched the defaults will go away.

Signed-off-by: Zygmunt Krynicki <email address hidden>

4070. By Pierre Equoy on 2015-10-28

"automatic merge of lp:~pierre-equoy/checkbox/fix-1471663-erroneous-wireless-results-when-eth-plugged/ by tarmac [r=sylvain-pineau][bug=1471663][author=pierre-equoy]"

4069. By Maciej Kisielewski on 2015-10-27

"automatic merge of lp:~kissiel/checkbox/minor-converged-fixes/ by tarmac [r=zyga][bug=][author=kissiel]"

4068. By Po-Hsu Lin on 2015-10-27

"automatic merge of lp:~cypressyew/checkbox/reduce-webcam-led-time/ by tarmac [r=zyga][bug=][author=cypressyew]"

4067. By Launchpad Translations on behalf of checkbox-dev on 2015-10-26

Launchpad automatic translations update.

4066. By Maciej Kisielewski on 2015-10-23

"automatic merge of lp:~kissiel/checkbox/minor-converged-fixes/ by tarmac [r=sylvain-pineau][bug=][author=kissiel]"

4065. By Po-Hsu Lin on 2015-10-23

"automatic merge of lp:~cypressyew/checkbox/rotation-from-normal/ by tarmac [r=sylvain-pineau][bug=1503167][author=cypressyew]"

4064. By Maciej Kisielewski on 2015-10-22

"automatic merge of lp:~kissiel/checkbox/fix-1501511-standard-close-icon/ by tarmac [r=sylvain-pineau,nik90][bug=1501511][author=kissiel]"