Merge lp:~zyga/checkbox/kill-oldcli into lp:checkbox

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 3996
Merged at revision: 3996
Proposed branch: lp:~zyga/checkbox/kill-oldcli
Merge into: lp:checkbox
Diff against target: 25 lines (+1/-7)
1 file modified
checkbox-ng/checkbox_ng/commands/cli.py (+1/-7)
To merge this branch: bzr merge lp:~zyga/checkbox/kill-oldcli
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+270406@code.launchpad.net
To post a comment you must log in.
lp:~zyga/checkbox/kill-oldcli updated
3996. By Zygmunt Krynicki

checkbox-ng:commands: remove the 'oldcli' interface

The old command line interface of checkbox-ng was something nobody used
for the past few months and it's inferior in every way. In order to cut
the amount of legacy code we have I'd like to remove it.

Signed-off-by: Zygmunt Krynicki <email address hidden>

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Rot removal FTW

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-ng/checkbox_ng/commands/cli.py'
2--- checkbox-ng/checkbox_ng/commands/cli.py 2015-03-17 13:05:59 +0000
3+++ checkbox-ng/checkbox_ng/commands/cli.py 2015-09-08 14:12:13 +0000
4@@ -28,7 +28,6 @@
5 from argparse import SUPPRESS
6 from gettext import gettext as _
7 from logging import getLogger
8-import argparse
9
10 from plainbox.impl.commands import PlainBoxCommand
11 from plainbox.impl.commands.cmd_checkbox import CheckBoxCommandMixIn
12@@ -64,12 +63,7 @@
13 parser = subparsers.add_parser(self.settings['subparser_name'],
14 help=self.settings['subparser_help'])
15 parser.set_defaults(command=self)
16- parser.set_defaults(dry_run=False, new_ui=True)
17- parser.add_argument(
18- '--new-ui', help=argparse.SUPPRESS, action='store_true')
19- parser.add_argument(
20- '--old-ui', dest='new_ui', help=argparse.SUPPRESS,
21- action='store_false')
22+ parser.set_defaults(dry_run=False)
23 parser.add_argument(
24 "--check-config",
25 action="store_true",

Subscribers

People subscribed via source and target branches