lp:~zyga/checkbox/fix-session-init

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 1999

Daniel Manrique (community): Approve on 2013-03-19

Diff: 201 lines (+96/-6)

5 files modified

plainbox/plainbox/impl/commands/run.py (+13/-1)
plainbox/plainbox/impl/depmgr.py (+9/-2)
plainbox/plainbox/impl/session.py (+40/-2)
plainbox/plainbox/impl/test_depmgr.py (+10/-0)
plainbox/plainbox/impl/test_session.py (+24/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1157264: plainbox crashes if duplicate test case names are present in the jobs files

Medium

Fix Released

Link a bug report

Related blueprints

2002. By Zygmunt Krynicki on 2013-03-19

run: handle duplicate jobs when constructing SessionState

This fixes lp: #1157264

This builds on earlier patches, when the job database is wrong and
contains duplicate jobs that are not identical then tell the operator
about where each job came from.

Signed-off-by: Zygmunt Krynicki <email address hidden>
Reported-by: Sean Feole <email address hidden>
Tested-by: Zygmunt Krynicki <email address hidden>

2001. By Zygmunt Krynicki on 2013-03-19

session: properly handle SessionState() called with duplicates

This is a part of fix to lp: #1157264

When SessionState() is initialized with a list containing duplicates
bad things happen. The error recovery code in update_desired_jobs()
is not prepared for any duplicates and things break in odd places.

To fix that, have SessionState reject duplicate jobs in the same way
that DependencySolver does. As a small exception to this rule, jobs
that are prefect clones are silently coalesced.

This makes the constructor of SessionState throw DependencyDuplicateError
exception when real problems have occurred and prevent any testing from
being started. Unlike local jobs that can also silently produce duplicate
jobs, having initial name clashes cannot be solved at this layer

Signed-off-by: Zygmunt Krynicki <email address hidden>
Reported-by: Sean Feole <email address hidden>

2000. By Zygmunt Krynicki on 2013-03-19

session: add xfailure tests for bug lp: #1157264

SessionState.__init__() does not detect passing duplicate jobs like
other parts of session do. This later causes spurious errors in dependency
solver.

This patch adds tests that expect to fail until bug gets fixed

Signed-off-by: Zygmunt Krynicki <email address hidden>
Reported-by: Sean Feole <email address hidden>

1999. By Zygmunt Krynicki on 2013-03-19

session: bump copyright

Signed-off-by: Zygmunt Krynicki <email address hidden>

1998. By Zygmunt Krynicki on 2013-03-19

depmgr: update docstrings about DependencyDuplicateError

Signed-off-by: Zygmunt Krynicki <email address hidden>

1997. By Zygmunt Krynicki on 2013-03-19

depmgr: add test for duplicate jobs

This test is pretty much identical to
DependencySolverInternalsTests.test_get_job_map_find_duplicates()
but it's nice to see that it just works

Signed-off-by: Zygmunt Krynicki <email address hidden>

1996. By Sylvain Pineau on 2013-03-19

"[r=zkrynicki][bug=][author=sylvain-pineau] XML exporter: Added support for attachments"

1995. By Zygmunt Krynicki on 2013-03-19

"[r=zkrynicki][bug=][author=zkrynicki] automatic merge by tarmac"

1994. By Jeff Marcom on 2013-03-18

"[r=zkrynicki][bug=1155686][author=jeffmarcom] automatic merge by tarmac"

1993. By Zygmunt Krynicki on 2013-03-18

"[r=zkrynicki][bug=][author=zkrynicki] automatic merge by tarmac"