Merge lp:~zyga/checkbox/fix-1483410 into lp:checkbox

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 3942
Merged at revision: 3943
Proposed branch: lp:~zyga/checkbox/fix-1483410
Merge into: lp:checkbox
Diff against target: 28 lines (+4/-3)
2 files modified
checkbox-support/checkbox_support/parsers/udevadm.py (+1/-1)
checkbox-support/checkbox_support/tests/__init__.py (+3/-2)
To merge this branch: bzr merge lp:~zyga/checkbox/fix-1483410
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Review via email: mp+267644@code.launchpad.net

Description of the change

This branch contains the upstream version of two patches for https://bugs.launchpad.net/ubuntu/+source/checkbox-support/+bug/1483410

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-support/checkbox_support/parsers/udevadm.py'
2--- checkbox-support/checkbox_support/parsers/udevadm.py 2015-06-10 14:35:44 +0000
3+++ checkbox-support/checkbox_support/parsers/udevadm.py 2015-08-11 11:03:33 +0000
4@@ -803,7 +803,7 @@
5 self.devices[device._raw_path] = device
6 stack.append(device)
7
8- for device in self.devices.values():
9+ for device in list(self.devices.values()):
10 if device.category in ("NETWORK", "WIRELESS", "OTHER"):
11 dev_interface = [
12 d for d in self.devices.values()
13
14=== modified file 'checkbox-support/checkbox_support/tests/__init__.py'
15--- checkbox-support/checkbox_support/tests/__init__.py 2014-05-20 18:54:18 +0000
16+++ checkbox-support/checkbox_support/tests/__init__.py 2015-08-11 11:03:33 +0000
17@@ -40,8 +40,9 @@
18 """
19 # Discover all unit tests. By simple convention those are kept in
20 # python modules that start with the word 'test_' .
21- return defaultTestLoader.discover(
22- os.path.dirname(getabsfile(checkbox_support)))
23+ start_dir = os.path.dirname(getabsfile(checkbox_support))
24+ top_level_dir = os.path.normpath(os.path.join(start_dir, '..'))
25+ return defaultTestLoader.discover(start_dir, top_level_dir=top_level_dir)
26
27
28 def test_suite():

Subscribers

People subscribed via source and target branches