lp:~zyga/checkbox/fix-1442148

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3670

Sylvain Pineau (community): Approve on 2015-04-09

Diff: 22 lines (+4/-3)

1 file modified

plainbox/plainbox/impl/job.py (+4/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1442148: potential infinitie recursion in JobTreeBuilder

Medium

Fix Released

Link a bug report

Related blueprints

3663. By Zygmunt Krynicki on 2015-04-09

plainbox:job: fix potential infinite recursion

This patch fixes a potential infinite recursion that may happen due to a
bug in sequence of calls in JobTreeBuilder.get_or_create_category_node().

The builder will create a parent category for each category that gets
added but will only update the category map once the whole operation is
complete. Since the function calls itself recursively it can keep trying
to create one category node over and over forever.

This patch moves the code that updates category_node_map directly to
JobTreeBuilder.create_category_node() so that the map is always
up-to-date.

Fixes: https://bugs.launchpad.net/plainbox/+bug/1442148

Signed-off-by: Zygmunt Krynicki <email address hidden>

3662. By Launchpad Translations on behalf of checkbox-dev on 2015-04-09

Launchpad automatic translations update.

3661. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/provider-dependencies/ by tarmac [r=kissiel,roadmr][bug=][author=zyga]"

3660. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/new-piglit-support/ by tarmac [r=][bug=][author=zyga]"

3659. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/fix-plainbox-i18n/ by tarmac [r=zyga][bug=][author=zyga]"

3658. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/build-i18n-tool/ by tarmac [r=zyga,roadmr][bug=][author=zyga]"

3657. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/fix-plainbox-packaging/ by tarmac [r=zyga][bug=][author=zyga]"

3656. By Po-Hsu Lin on 2015-04-08

"automatic merge of lp:~cypressyew/checkbox/allow-invariant-cmd/ by tarmac [r=zyga][bug=1441519][author=cypressyew]"

3655. By Zygmunt Krynicki on 2015-04-08

"automatic merge of lp:~zyga/checkbox/fix-plainbox-packaging/ by tarmac [r=sylvain-pineau][bug=][author=zyga]"

3654. By Sylvain Pineau on 2015-04-07

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1440553/ by tarmac [r=zyga,roadmr][bug=][author=sylvain-pineau]"