lp:~zyga/checkbox/fix-1441993

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3680

Sylvain Pineau (community): Approve on 2015-04-10

Diff: 318 lines (+153/-98)

2 files modified

plainbox/plainbox/impl/ctrl.py (+58/-1)
plainbox/plainbox/impl/test_ctrl.py (+95/-97)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1441993: via job cycles cause infinite recursion in get_or_create_category_node()

Critical

Fix Released

Link a bug report

Related blueprints

3678. By Zygmunt Krynicki on 2015-04-10

plainbox:ctrl: detect and break via cycles

This patch changes the CheckBoxSessionStateController to pay extra
attention not to create via cycles when processing local jobs.

Fixes: https://bugs.launchpad.net/plainbox/+bug/1441993https://bugs.launchpad.net/plainbox/+bug/1441993

Signed-off-by: Zygmunt Krynicki <email address hidden>

3677. By Zygmunt Krynicki on 2015-04-10

plainbox:ctrl: add get_via_cycle()

This patch adds a function that detects cycles in via connections.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3676. By Zygmunt Krynicki on 2015-04-10

plainbox:ctrl: rewrite tests for local jobs

This patch rewrites three tests for local jobs, not changing their
semantics but changing the implementation. The original implementation
used mocking for everything and focused on observing impact of the
session controller on the mocked session. This turned out to be difficult
to adapt to changes to the controller so instead non-mocked objects are
used and minimal mocking is used as a short-cut (to remove the necessity
to create real results that correctly define jobs).

Signed-off-by: Zygmunt Krynicki <email address hidden>

3675. By Launchpad Translations on behalf of checkbox-dev on 2015-04-10

Launchpad automatic translations update.

3674. By Sylvain Pineau on 2015-04-09

"automatic merge of lp:~sylvain-pineau/checkbox/remove_wrong_get_stats/ by tarmac [r=sylvain-pineau][bug=][author=sylvain-pineau]"

3673. By Sylvain Pineau on 2015-04-09

"automatic merge of lp:~sylvain-pineau/checkbox/html_legacy_jinja_template/ by tarmac [r=sylvain-pineau,zyga][bug=1433873][author=sylvain-pineau]"

3672. By Sylvain Pineau on 2015-04-09

"automatic merge of lp:~sylvain-pineau/checkbox/get_outcome_stats/ by tarmac [r=zyga][bug=][author=sylvain-pineau]"

3671. By Zygmunt Krynicki on 2015-04-09

"automatic merge of lp:~zyga/checkbox/fix-1442139/ by tarmac [r=sylvain-pineau][bug=1442139][author=zyga]"

3670. By Zygmunt Krynicki on 2015-04-09

"automatic merge of lp:~zyga/checkbox/fix-1442148/ by tarmac [r=sylvain-pineau][bug=1442148][author=zyga]"

3669. By Zygmunt Krynicki on 2015-04-09

"automatic merge of lp:~zyga/checkbox/fix-1430292/ by tarmac [r=sylvain-pineau][bug=1430292][author=zyga]"