Merge lp:~zyga/checkbox/fix-1413134 into lp:checkbox

[Zygmunt Krynicki]

04dc495 providers:checkbox: run {poweroff,reboot} in the foreground

This can be verified by running:

sudo ./providers/plainbox-provider-checkbox/bin/pm_test poweroff; echo 'FAILED' > ~/did-it-fail

And checking the contents of ~/did-it-fail after re-powering the machine.

[Maciej Kisielewski (kissiel)]

I've run a couple of tests to check how this change affects https://bugs.launchpad.net/plainbox/+bug/1403832
By making pm_test run comamnds serially (instead of forking) it solves the rebooting problem as well.

[Maciej Kisielewski (kissiel)]

+1, thanks

review: Approve

=== modified file 'providers/plainbox-provider-checkbox/bin/pm_test'
--- providers/plainbox-provider-checkbox/bin/pm_test	2014-12-07 22:46:56 +0000
+++ providers/plainbox-provider-checkbox/bin/pm_test	2015-01-21 14:22:07 +0000
@@ -7,6 +7,7 @@
 import shutil
 import subprocess
 import sys
+import signal
 
 from argparse import ArgumentParser, SUPPRESS
 from calendar import timegm
@@ -143,7 +144,11 @@
         logging.info('Executing new {0!r} operation...'
                      .format(self.args.pm_operation))
         logging.debug('Executing: {0!r}...'.format(command_str))
-        subprocess.Popen(command_str, shell=True)
+        # The PM operation is performed asynchronously so let's just wait
+        # indefinitely until it happens and someone comes along to kill us.
+        # This addresses LP: #1413134
+        subprocess.check_call(command_str, shell=True)
+        signal.pause()
 
     def summary(self):
         """