lp:~zyga/checkbox/fix-1402421

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:checkbox

Checkbox Developers: Pending requested 2014-12-15

Diff: 239 lines (+67/-28)

3 files modified

plainbox/plainbox/vendor/extcmd/glibc.py (+2/-2)
plainbox/plainbox/vendor/pyglibc/__init__.py (+2/-0)
plainbox/plainbox/vendor/pyglibc/_pthread_sigmask.py (+63/-26)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1402421: BlockingIOError: [Errno 11] The file descriptor fd refers to a file other than a socket and has been marked nonblocking

High

Won't Fix

Link a bug report

Related blueprints

3507. By Zygmunt Krynicki on 2014-12-15

plainbox:vendor:extcmd use process-wide signal masks

This patch changes extcmd to use process-wide signal masks (aka
sigprocmask vs pthread_sigmask). This fixes a problem where in a
multi-threaded application, extcmd might misbehave if the SIGCHLD signal
was delivered to a different thread than the one running extcmd's event
loop. When that happens the signal itself is consumed and subsequent
read from signalfd() would return EAGAIN (aka errno 11, aka
BlockingIOError).

The precise sequence of events that need to happen in
order to trigger this bug is:

- assume that there is a process P1, running two threads T1 and T2.
  Extcmd is running in T1 and has blocked SIGCHLD (so that it can be
  collected via epoll-triggered signalfd). T2 runs unrelated code.
- assume that there is a process P2, that is a child of P1, that has
  just exited.
- the signal is enqueued as readable via signalfd, waking up T1
- since P1's T1 is blocking SIGCHLD, the signal is delivered to T2.
- T1 tries to read() from signalfd and receives EAGAIN

The patch fixes this so that no matter how the scheduling orders events,
this will happen:

- assume that there is a process P1, running two threads T1 and T2.
  Extcmd is running in T1 and has blocked SIGCHLD (so that it can be
  collected via epoll-triggered signalfd). T2 runs unrelated code.
- assume that there is a process P2, that is a child of P1, that has
  just exited.
- the signal is enqueued as readable via signalfd, waking up T1
- since P1 is blocking SIGCHLD for all threads the signal is not
  delivered
- T1 reads signal details from signalfd

Fixes: https://bugs.launchpad.net/plainbox/+bug/1402421

Signed-off-by: Zygmunt Krynicki <email address hidden>

3506. By Zygmunt Krynicki on 2014-12-15

plainbox:vendor:glibc: fix man page ref for pthread_sigmask

Signed-off-by: Zygmunt Krynicki <email address hidden>

3505. By Zygmunt Krynicki on 2014-12-15

plainbox:vendor:glibc: add sigprocmask

This patch adds a trivial implementation of sigprocmask, based on
_sigxxxmask_base. This allows one to use either process-wide or
per-thread signal blocks using the same API.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3504. By Zygmunt Krynicki on 2014-12-15

plainbox:vendor:glibc: refactor pthread_sigmask

This patch refactors the pthread_sigmaks into a generic base class
_sigxxxmask_base that can now be used to trivially implement
pthread_sigmask and, in the upcoming patch, sigprocmask.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3503. By Launchpad Translations on behalf of checkbox-dev on 2014-12-13

Launchpad automatic translations update.

3502. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/fix-1401996/ by tarmac [r=roadmr][bug=1401996][author=zkrynicki]"

3501. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/fix-1401927/ by tarmac [r=sylvain-pineau][bug=1401927][author=zkrynicki]"

3500. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/attachment-fixes/ by tarmac [r=sylvain-pineau][bug=1401886][author=zkrynicki]"

3499. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/extcmd-abnormal-end/ by tarmac [r=sylvain-pineau][bug=][author=zkrynicki]"

3498. By Maciej Kisielewski on 2014-12-12

"automatic merge of lp:~kissiel/checkbox/fix-1399623/ by tarmac [r=zkrynicki][bug=1399623][author=kissiel]"