lp:~zyga/checkbox/fix-1401996

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3502

Daniel Manrique (community): Approve on 2014-12-12

Diff: 68 lines (+39/-5)

1 file modified

plainbox/plainbox/vendor/extcmd/glibc.py (+39/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1401996: extcmd based on glibc must respect the on_line() protocol

Critical

Fix Released

Link a bug report

Related blueprints

3502. By Zygmunt Krynicki on 2014-12-12

plainbox:vendor:extcmd: respect the on_line() protocol

This patch changes the glibc-based implementation of extcmd to correctly
respect the extcmd's on_line() protocol. This means, that when a chunk
of data is read, it must be first split into distinct lines and only
such split bytes should be passed to the on_line(). Adherence to the
protocol should be maintained even when processing partial lines, that
is lines which are half-way read (before the '\n' byte is seen).

In practical terms, the _read_pipe() method now gets a helper argument
which stores partial data and all new data is (after being combined with
data left over from the previous call to _read_pipe()) split into
distinct lines.

Fixes: https://bugs.launchpad.net/plainbox/+bug/1401996

Signed-off-by: Zygmunt Krynicki <email address hidden>

3501. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/fix-1401927/ by tarmac [r=sylvain-pineau][bug=1401927][author=zkrynicki]"

3500. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/attachment-fixes/ by tarmac [r=sylvain-pineau][bug=1401886][author=zkrynicki]"

3499. By Zygmunt Krynicki on 2014-12-12

"automatic merge of lp:~zkrynicki/checkbox/extcmd-abnormal-end/ by tarmac [r=sylvain-pineau][bug=][author=zkrynicki]"

3498. By Maciej Kisielewski on 2014-12-12

"automatic merge of lp:~kissiel/checkbox/fix-1399623/ by tarmac [r=zkrynicki][bug=1399623][author=kissiel]"

3497. By Sylvain Pineau on 2014-12-11

"automatic merge of lp:~sylvain-pineau/checkbox/export_flags/ by tarmac [r=zkrynicki][bug=][author=sylvain-pineau]"

3496. By Zygmunt Krynicki on 2014-12-11

"automatic merge of lp:~zkrynicki/checkbox/glibc-extcmd/ by tarmac [r=sylvain-pineau][bug=][author=zkrynicki]"

3495. By Sylvain Pineau on 2014-12-11

"automatic merge of lp:~sylvain-pineau/checkbox/client-cert-regression/ by tarmac [r=zkrynicki][bug=][author=sylvain-pineau]"

3494. By Maciej Kisielewski on 2014-12-10

"automatic merge of lp:~kissiel/checkbox/common-dialog/ by tarmac [r=zkrynicki][bug=][author=kissiel]"

3493. By Zygmunt Krynicki on 2014-12-09

"automatic merge of lp:~zkrynicki/checkbox/test-plan-fixes/ by tarmac [r=roadmr][bug=][author=zkrynicki]"