Merge lp:~zyga/checkbox/fix-1319327 into lp:checkbox

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 2997
Merged at revision: 2998
Proposed branch: lp:~zyga/checkbox/fix-1319327
Merge into: lp:checkbox
Diff against target: 27 lines (+3/-3)
1 file modified
checkbox-gui/checkbox-gui/qml/TestSelectionListView.qml (+3/-3)
To merge this branch: bzr merge lp:~zyga/checkbox/fix-1319327
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+219492@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I just hope that we don't have other places like this one.

Thanks for the fix

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-gui/checkbox-gui/qml/TestSelectionListView.qml'
2--- checkbox-gui/checkbox-gui/qml/TestSelectionListView.qml 2014-02-19 11:31:39 +0000
3+++ checkbox-gui/checkbox-gui/qml/TestSelectionListView.qml 2014-05-14 10:47:55 +0000
4@@ -442,12 +442,12 @@
5 function updateListSummary(testItem, sel){
6 if (sel){
7 totalTests += 1;
8- if (testItem.type === "Manual")
9+ if (testItem.type === i18n.tr("Manual"))
10 totalManualTests += 1;
11 }
12 else {
13 totalTests -= 1;
14- if (testItem.type === "Manual")
15+ if (testItem.type === i18n.tr("Manual"))
16 totalManualTests -= 1
17 }
18 }
19@@ -472,7 +472,7 @@
20 // not a branch
21 if ( curItem.check === "true"){
22 testCnt++;
23- if (curItem.type === "Manual")
24+ if (curItem.type === i18n.tr("Manual"))
25 manualCnt++;
26 estTimeInt = parseInt(curItem.duration) + parseInt(estTimeInt);
27 }

Subscribers

People subscribed via source and target branches