Merge lp:~zyga/checkbox/fix-1306051 into lp:checkbox

[Zygmunt Krynicki]

8afe5b7 plainbox:provider_manager: don't create bin/ blindly

[Daniel Manrique (roadmr)]

+1, easy enough. No tests:

12:32 < zyga> roadmr: there are no tests as provider_manager has no unit tests and clearly
              has not enough intergration tests to make that change matter
12:32 < zyga> roadmr: I thought about adding more but I need to refactor some code first,
              to make creating testbeds like that easier

review: Approve

=== modified file 'plainbox/plainbox/provider_manager.py'
--- plainbox/plainbox/provider_manager.py	2014-04-04 16:16:31 +0000
+++ plainbox/plainbox/provider_manager.py	2014-04-10 16:31:52 +0000
@@ -267,13 +267,16 @@
                 layout, prefix, provider).write(stream))
 
     def _copy_all_executables(self, root, prefix, layout, provider):
+        executable_list = provider.get_all_executables()
+        if not executable_list:
+            return
         dest_map = self._get_dest_map(layout, prefix)
         dest_bin_dir = root + dest_map['bin']
         try:
             os.makedirs(dest_bin_dir, exist_ok=True)
         except IOError:
             pass
-        for executable in provider.get_all_executables():
+        for executable in executable_list:
             shutil.copy(executable, dest_bin_dir)
 
     def _copy_all_data(self, root, prefix, layout):