lp:~zyga/checkbox/fix-1298452

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 2842

Brendan Donegan (community): Approve on 2014-03-28

Diff: 40 lines (+7/-11)

2 files modified

plainbox/plainbox/impl/secure/providers/test_v1.py (+6/-7)
plainbox/plainbox/impl/secure/providers/v1.py (+1/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1298452: CHECKBOX_SHARE should match provider location: field

Medium

Fix Released

Link a bug report

Related blueprints

2842. By Zygmunt Krynicki on 2014-03-28

plainbox:secure:providers: implement CHECKBOX_SHARE with Provider1.base_dir

Fixes: https://bugs.launchpad.net/checkbox/+bug/1298452

Signed-off-by: Zygmunt Krynicki <email address hidden>

2841. By Zygmunt Krynicki on 2014-03-28

"automatic merge by tarmac [r=brendan-donegan][bug=1298392][author=zkrynicki]"

2840. By Launchpad Translations on behalf of checkbox-dev on 2014-03-28

Launchpad automatic translations update.

2839. By Daniel Manrique on 2014-03-27

"Adds the audio plug detection tests to the certification and self-test whitelists. Note the 12.04 whitelists are untouched as we don't retroactively update coverage for releases. [r=zkrynicki][bug=][author=roadmr]"

2838. By Daniel Manrique on 2014-03-27

"Added the estimated_duration to the stress sdhc test. [r=zkrynicki][bug=1298545][author=roadmr]"

2837. By Daniel Manrique on 2014-03-27

"Updated stress test to prompt user prior to running, adding instructions as well [r=zkrynicki][bug=1298545][author=roadmr]"

2836. By Daniel Manrique on 2014-03-27

"Fixes the dmi_attachment failure bug by "eating" the bad exit code. There's some shell magic to ensure that if the top directory is unreadable, it *does* exit with an error code.

If run as a normal user, it fails to read some files. If run as root, there's one special file that it also fails to read.

The list of files it can't read is in the bug report. I checked and the exit code is indeed 2 (errors). So grep is behaving correctly; it's telling us it couldn't read some of the files. The fact that the output is suppressed means this was expected; previously we relied on checkbox "eating" the exit code for resource jobs to keep that from showing up in the test reports.

We care about grep's output, consisting of lines like:

/sys/class/dmi/id/chassis_version:0.1
/sys/class/dmi/id/bios_date:12/11/2013
/sys/class/dmi/id/bios_version:A02
/sys/class/dmi/id/sys_vendor:Dell Inc.

The bug mentioned that this information might be unnecessary now, as we have the full dmidecode_attachment and we shouldn't need this rather primitive dmi output. That could use a bit more research. For instance we could do a run with dmi_attachment and one without, and run the submissions through the parser, if they don't produce different output then we conceivably don't need dmi_attachment. [r=zkrynicki][bug=1238009][author=roadmr]"

2835. By Zygmunt Krynicki on 2014-03-27

"automatic merge by tarmac [r=roadmr][bug=1297118][author=zkrynicki]"

2834. By Ashley Lai on 2014-03-27

"automatic merge by tarmac [r=zkrynicki][bug=1296956][author=alai]"

2833. By Zygmunt Krynicki on 2014-03-27

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"