Merge lp:~zyga/checkbox/fix-1297255 into lp:checkbox

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 2850
Merged at revision: 2852
Proposed branch: lp:~zyga/checkbox/fix-1297255
Merge into: lp:checkbox
Diff against target: 45 lines (+9/-1)
2 files modified
plainbox/plainbox/provider_manager.py (+2/-1)
plainbox/plainbox/test_provider_manager.py (+7/-0)
To merge this branch: bzr merge lp:~zyga/checkbox/fix-1297255
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+213379@code.launchpad.net

Description of the change

7647bb6 plainbox:provider_manager: put src/ into source tarball

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/provider_manager.py'
2--- plainbox/plainbox/provider_manager.py 2014-03-29 15:45:52 +0000
3+++ plainbox/plainbox/provider_manager.py 2014-03-30 12:23:09 +0000
4@@ -349,6 +349,7 @@
5 - the jobs directory, and everything in it
6 - the whitelists directory, and everything in it
7 - the bin directory, and everything in it
8+ - the src directory, and everything in it
9 - the data directory, and everything in it
10 - the po directory, and everything in it
11
12@@ -359,7 +360,7 @@
13 name = "sdist"
14
15 _INCLUDED_ITEMS = ['manage.py', 'README.md', 'jobs', 'whitelists', 'bin',
16- 'data', 'po']
17+ 'src', 'data', 'po']
18
19 def register_parser(self, subparsers):
20 """
21
22=== modified file 'plainbox/plainbox/test_provider_manager.py'
23--- plainbox/plainbox/test_provider_manager.py 2014-03-29 15:45:52 +0000
24+++ plainbox/plainbox/test_provider_manager.py 2014-03-30 12:23:09 +0000
25@@ -188,6 +188,9 @@
26 self.assertTarballContent(
27 tarball, "2014.com.example.test-1.0/bin/test.sh",
28 "#!/bin/sh\n:\n")
29+ self.assertTarballContent(
30+ tarball, "2014.com.example.test-1.0/src/hello.c",
31+ "int main() { return 0; }\n")
32
33 def test_sdist(self):
34 """
35@@ -376,6 +379,10 @@
36 print("#!/bin/sh", file=stream)
37 print(":", file=stream)
38 os.chmod(filename, 0o755)
39+ os.mkdir(os.path.join(tmpdir, "src"))
40+ filename = os.path.join(tmpdir, "src", "hello.c")
41+ with open(filename, "wt", encoding='UTF-8') as stream:
42+ print("int main() { return 0; }", file=stream)
43 definition = Provider1Definition()
44 definition.location = tmpdir
45 definition.name = "2014.com.example:test"

Subscribers

People subscribed via source and target branches