Checkbox

Merge lp:~zyga/checkbox/fix-1252359 into lp:checkbox

  1. fix-1252359
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 2540
Merged at revision: 2548
Proposed branch: lp:~zyga/checkbox/fix-1252359
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
plainbox/plainbox/impl/runner.py (+1/-1)
To merge this branch: bzr merge lp:~zyga/checkbox/fix-1252359
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+197915@code.launchpad.net

Description of the change

7ab8a15 plainbox:runner: fix support for user-interact jobs

I'll work on fixing the broken plainbox 'run' interface (and probably copy-broken checkbox-ng) and adding appropriate tests in a separate branch. For now please test this fix and report back.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Nice and easy fix, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/runner.py'
2--- plainbox/plainbox/impl/runner.py 2013-11-27 20:40:19 +0000
3+++ plainbox/plainbox/impl/runner.py 2013-12-05 16:11:19 +0000
4@@ -433,7 +433,7 @@
5 """
6 if job.plugin != "user-interact":
7 raise ValueError("bad job plugin value")
8- return MemoryJobResult({'outcome': IJobResult.OUTCOME_UNDECIDED})
9+ return self._just_run_command(job, config)
10
11 def run_user_verify_job(self, job, config):
12 """

Subscribers

People subscribed via source and target branches