Merge lp:~zyga/checkbox/checkbox-packaging into lp:~checkbox-dev/checkbox/checkbox-packaging

Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Daniel Manrique
Approved revision: no longer in the source branch.
Merged at revision: 35
Proposed branch: lp:~zyga/checkbox/checkbox-packaging
Merge into: lp:~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 94 lines (+38/-11)
4 files modified
debian/checkbox-autostart-desktop.install (+1/-1)
debian/checkbox-autostart-server.install (+1/-1)
debian/checkbox-ci-mailer.install (+1/-1)
debian/control (+35/-8)
To merge this branch: bzr merge lp:~zyga/checkbox/checkbox-packaging
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+194213@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

This looks OK, just some renaming and moving files and a few transitional packages.

Do you want to remove the plainbox-autostart-* transitional packages now? I think they're only used in checkbox-
satellite deployments so as long as we push the corresponding changes today and alert everybody to upgrade, we should be OK. Or we can do it in a more staggered fashion.

+1 but I won't pull the approval trigger until I hear about this.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

ok, I'll approve this now, we can remove those packages later it's no rush :)

lp:~zyga/checkbox/checkbox-packaging updated
35. By Zygmunt Krynicki

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

On śro, lis 6, 2013 o 9:29 , Daniel Manrique
<email address hidden> wrote:
> Review: Approve
>
> This looks OK, just some renaming and moving files and a few
> transitional packages.
>
> Do you want to remove the plainbox-autostart-* transitional packages
> now? I think they're only used in checkbox-
> satellite deployments so as long as we push the corresponding changes
> today and alert everybody to upgrade, we should be OK. Or we can do
> it in a more staggered fashion.
>

Not yet. We can look at removing them afterr a few weeks. I wonder what
the policy says on transitional packages like that.

Thanks
ZK
>
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'debian/plainbox-autostart-desktop.install' => 'debian/checkbox-autostart-desktop.install'
2--- debian/plainbox-autostart-desktop.install 2013-10-23 07:01:08 +0000
3+++ debian/checkbox-autostart-desktop.install 2013-11-06 19:06:37 +0000
4@@ -1,1 +1,1 @@
5-plainbox/plainbox/data/plainbox.desktop etc/xdg/autostart
6+checkbox-ng/contrib/checkbox-sru.desktop etc/xdg/autostart
7
8=== renamed file 'debian/plainbox-autostart-server.install' => 'debian/checkbox-autostart-server.install'
9--- debian/plainbox-autostart-server.install 2013-10-23 07:01:08 +0000
10+++ debian/checkbox-autostart-server.install 2013-11-06 19:06:37 +0000
11@@ -1,1 +1,1 @@
12-plainbox/plainbox/data/plainbox.conf etc/init
13+checkbox-ng/contrib/checkbox-sru.conf etc/init
14
15=== renamed file 'debian/plainbox-ci-mailer.install' => 'debian/checkbox-ci-mailer.install'
16--- debian/plainbox-ci-mailer.install 2013-10-23 07:01:08 +0000
17+++ debian/checkbox-ci-mailer.install 2013-11-06 19:06:37 +0000
18@@ -1,1 +1,1 @@
19-plainbox/plainbox/data/plainbox-ci-mailer.conf etc/init
20+checkbox-ng/contrib/checkbox-ci-mailer.conf etc/init
21
22=== modified file 'debian/control'
23--- debian/control 2013-11-06 14:35:09 +0000
24+++ debian/control 2013-11-06 19:06:37 +0000
25@@ -254,6 +254,7 @@
26 Package: python3-checkbox-ng
27 Architecture: all
28 Depends: python3-plainbox (>= 0.3+bzr2359),
29+ python3-requests ( >= 1.0),
30 ${misc:Depends},
31 ${python3:Depends}
32 Description: Simple replacement for CheckBox
33@@ -283,17 +284,35 @@
34
35 Package: plainbox-autostart-desktop
36 Architecture: all
37-Depends: plainbox, plainbox-insecure-policy
38+Priority: extra
39+Section: oldlibs
40+Depends: checkbox-autostart-destkop
41 Description: PlainBox autostart for desktop install
42- File(s) needed for starting PlainBox automatically after login on a desktop
43- install.
44+ Transitional package that can be safely removed
45
46 Package: plainbox-autostart-server
47 Architecture: all
48-Depends: plainbox, plainbox-insecure-policy
49+Priority: extra
50+Section: oldlibs
51+Depends: checkbox-autostart-server
52 Description: PlainBox autostart for server install
53- File(s) needed for starting PlainBox automatically after boot on a server
54- install.
55+ Transitional package that can be safely removed
56+
57+Package: checkbox-autostart-desktop
58+Architecture: all
59+Depends: checkbox, plainbox-insecure-policy
60+Description: CheckBox autostart for desktop install
61+ Installing this package will automatically invoke 'checkbox sru' after the
62+ desktop session is started. This package should be only installed in automated
63+ testing environment.
64+
65+Package: checkbox-autostart-server
66+Architecture: all
67+Depends: checkbox, plainbox-insecure-policy
68+Description: CheckBox autostart for server install
69+ Installing this package will automatically invoke 'checkbox sru' after a
70+ server installation finishes booting. This package should be only installed in
71+ automated testing environment.
72
73 Package: plainbox-secure-policy
74 Architecture: all
75@@ -312,9 +331,17 @@
76
77 Package: plainbox-ci-mailer
78 Architecture: all
79-Depends: curl, plainbox-autostart-server | plainbox-autostart-desktop
80+Priority: extra
81+Section: oldlibs
82+Depends: checkbox-ci-mailer
83 Description: PlainBox CI mailer
84- Helper that e-mails PlainBox output from autostart packages when run is
85+ Transitional package that can be safely removed
86+
87+Package: checkbox-ci-mailer
88+Architecture: all
89+Depends: curl, checkbox-autostart-server | checkbox-autostart-desktop
90+Description: CheckBox CI mailer
91+ Helper that e-mails CheckBox output from autostart packages when run is
92 finished.
93
94 Package: plainbox-ihv-demo-config

Subscribers

People subscribed via source and target branches