lp:~zyga/checkbox/better-plugins

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 2573

Zygmunt Krynicki (community): Approve on 2013-12-20

Brendan Donegan (community): Approve on 2013-12-20

Diff: 697 lines (+425/-51)

2 files modified

plainbox/plainbox/impl/secure/plugins.py (+127/-22)
plainbox/plainbox/impl/secure/test_plugins.py (+298/-29)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2583. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: unify fake_open() functions

Signed-off-by: Zygmunt Krynicki <email address hidden>

2582. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: support multiple extensions

This patch adds support for multiple file extensions in
FsPlugInCollection. By passing any sequence-like object instead of a
plain string any of the extensions contained therein are accepted.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2581. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: handle OSError in FSPlugInCollection

This patch makes FSPlugInCollection handle both OSError and IOError
since IOError can happen in read (this was already handled) but OSError
can happen on open().

Signed-off-by: Zygmunt Krynicki <email address hidden>

2580. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add a way to pass extra arguments to wrappers

This patch makes it possible to pass additional arguments to
each instantiated wrapper object. This can be especially useful when
using custom wrappers that may need extra arguments to be properly
constructed.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2579. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add IPlugInCollection.get_all_plugin_objects()

This patch adds a new utility method to IPlugInCollection, that returns
a list of all the objects exposed by all of the loaded plugin objects.
This is basically the list of things other pieces of code needs to work
with so having it via one method should simplify other parts of the app.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2578. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add a way to track problems in plugin collection

This patch adds a new instance argument, _problem_list, which collects
all exceptions raised when trying to discover and load plugins.

Signed-off-by: Zygmunt Krynicki <email address hidden>

2577. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add docstrings for PlugInCollectionBase

Signed-off-by: Zygmunt Krynicki <email address hidden>

2576. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add docstrings for PlugIn

Signed-off-by: Zygmunt Krynicki <email address hidden>

2575. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add docstrings for PkgResourcesPlugInCollectionTests

Signed-off-by: Zygmunt Krynicki <email address hidden>

2574. By Zygmunt Krynicki on 2013-12-20

plainbox:secure:plugins: add tests for PlugInCollectionBase

This patch also removes a duplicate, older test for
PlugInCollectionBase.fake_plugins() that was added to another class.

Signed-off-by: Zygmunt Krynicki <email address hidden>