Merge lp:~zyga/checkbox/autocomplete-support into lp:checkbox

[Zygmunt Krynicki]

Something I digged out out of my sprint branch:

63eecf5 support: update external taraballs revision to latest
e6b3ebc plainbox:requirements: re-enable argcomplete installation
77f29bb plainbox: add crude autocompletion support to plainbox run

[Maciej Kisielewski (kissiel)]

+1

review: Approve

[Daniel Manrique (roadmr)]

The attempt to merge lp:~zkrynicki/checkbox/autocomplete-support into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.06user 0.02system 0:04.22elapsed 2%CPU (0avgtext+0avgdata 7864maxresident)k
[precise] (timing) 0inputs+32outputs (0major+5772minor)pagefaults 0swaps
[precise] provisioning container
[precise] (timing) 38.30user 11.79system 1:18.06elapsed 64%CPU (0avgtext+0avgdata 51204maxresident)k
[precise] (timing) 0inputs+16344outputs (0major+4289042minor)pagefaults 0swaps
[precise-testing] Starting tests...
Found a test script: ./checkbox-gui/requirements/container-tests-checkbox-gui-build
[precise-testing] container-tests-checkbox-gui-build: PASS
[precise-testing] (timing) 33.92user 2.47system 0:36.90elapsed 98%CPU (0avgtext+0avgdata 116364maxresident)k
[precise-testing] (timing) 0inputs+4240outputs (0major+477933minor)pagefaults 0swaps
Found a test script: ./checkbox-ng/requirements/container-tests-checkbox-ng-unit
[precise-testing] container-tests-checkbox-ng-unit: FAIL
[precise-testing] stdout: http://paste.ubuntu.com/7988784/
[precise-testing] stderr: http://paste.ubuntu.com/7988785/
[precise-testing] (timing) Command exited with non-zero status 1
[precise-testing] (timing) 0.58user 0.14system 0:00.77elapsed 95%CPU (0avgtext+0avgdata 37084maxresident)k
[precise-testing] (timing) 0inputs+2968outputs (0major+19112minor)pagefaults 0swaps
Found a test script: ./checkbox-support/requirements/container-tests-checkbox-support
[precise-testing] container-tests-checkbox-support: PASS
[precise-testing] (timing) 17.64user 0.17system 0:17.97elapsed 99%CPU (0avgtext+0avgdata 82440maxresident)k
[precise-testing] (timing) 0inputs+976outputs (0major+30676minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/001-container-tests-plainbox-egg-info
[precise-testing] 001-container-tests-plainbox-egg-info: PASS
[precise-testing] (timing) 0.16user 0.03system 0:00.21elapsed 90%CPU (0avgtext+0avgdata 10396maxresident)k
[precise-testing] (timing) 0inputs+80outputs (0major+4950minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox
[precise-testing] container-tests-plainbox: FAIL
[precise-testing] stdout: http://paste.ubuntu.com/7988788/
[precise-testing] stderr: http://paste.ubuntu.com/7988789/
[precise-testing] (timing) Command exited with non-zero status 1
[precise-testing] (timing) 4.73user 0.27system 0:05.05elapsed 99%CPU (0avgtext+0avgdata 64444maxresident)k
[precise-testing] (timing) 0inputs+2456outputs (0major+48764minor)pagefaults 0swaps
Found a test script: ./plainbox/requirements/container-tests-plainbox-documentation
[precise-testing] container-tests-plainbox-documentation: FAIL
[precise-testing] stdout: http://paste.ubuntu.com/7988791/
[precise-testing] stderr: http://paste.ubuntu.com/7988792/
[precise-testing] (timing) Command exited with non-zero status 1
[precise-testing] (timing) 1.20user 0.10system 0:01.35elapsed 96%CPU (0avgtext+0avgdata 39088maxresident)k
[precise-testing] (timing) 0inputs+1944outputs (0major+16598minor)pagefaults 0swaps
Foun...

[Zygmunt Krynicki (zyga)]

Damn,

  File "/usr/local/lib/python3.2/dist-packages/argcomplete/__init__.py",
line 185

Argcomplete doesn't support python3.2

On Fri, Aug 8, 2014 at 3:28 PM, Daniel Manrique
<email address hidden> wrote:
> The proposal to merge lp:~zkrynicki/checkbox/autocomplete-support into lp:checkbox has been updated.
>
> Status: Approved => Needs review
>
> For more details, see:
> https://code.launchpad.net/~zkrynicki/checkbox/autocomplete-support/+merge/230096
> --
> https://code.launchpad.net/~zkrynicki/checkbox/autocomplete-support/+merge/230096
> You are the owner of lp:~zkrynicki/checkbox/autocomplete-support.

[Sylvain Pineau (sylvain-pineau)]

Anything we can fix?

review: Needs Information

[Zygmunt Krynicki (zyga)]

Unfortunately nothing we can fix in our own project. Upstream developers dropposed support for python3.2 (in favour of simplier 2.7+ support granted by python's 3.3 'u' feature)

Unmerged revisions

3176. By Zygmunt Krynicki on 2014-08-08

plainbox: add crude autocompletion support to plainbox run

This patch adds autocomplete support to 'plainbox run -i' and 'plainbox
run -x'. Both complete providers namespaces and then job definition
identifiers.

The crudeness is related to the fact that this operation is very slow
today. It feels quite painful to operate (but works well otherwise).
Still, with this enabled we can easily observe impact of any app-startup
optimizations and the performance of provider cache that is in the
works.

Signed-off-by: Zygmunt Krynicki <email address hidden>

3175. By Zygmunt Krynicki on 2014-08-08

plainbox:requirements: re-enable argcomplete installation

Signed-off-by: Zygmunt Krynicki <email address hidden>

3174. By Zygmunt Krynicki on 2014-08-08

support: update external taraballs revision to latest

Signed-off-by: Zygmunt Krynicki <email address hidden>

=== modified file 'plainbox/plainbox/impl/commands/checkbox.py'
--- plainbox/plainbox/impl/commands/checkbox.py	2014-03-27 21:58:41 +0000
+++ plainbox/plainbox/impl/commands/checkbox.py	2014-08-08 12:19:52 +0000
@@ -138,21 +138,29 @@
     jobs
     """
 
-    def enhance_parser(self, parser):
+    def enhance_parser(self, parser, provider_list=None):
         """
         Add common options for job selection to an existing parser
         """
+        if provider_list is not None:
+            id_completer = JobIdCompleter(provider_list)
+        else:
+            id_completer = None
         group = parser.add_argument_group(title=_("job definition options"))
-        group.add_argument(
+        action = group.add_argument(
             '-i', '--include-pattern', action="append",
             metavar=_('PATTERN'), default=[], dest='include_pattern_list',
             # TRANSLATORS: this is in imperative form
             help=_("include jobs matching the given regular expression"))
-        group.add_argument(
+        if id_completer is not None:
+            action.completer = id_completer
+        action = group.add_argument(
             '-x', '--exclude-pattern', action="append",
             metavar=_("PATTERN"), default=[], dest='exclude_pattern_list',
             # TRANSLATORS: this is in imperative form
             help=_("exclude jobs matching the given regular expression"))
+        if id_completer is not None:
+            action.completer = id_completer
         # TODO: Find a way to handle the encoding of the file
         group.add_argument(
             '-w', '--whitelist',
@@ -162,3 +170,28 @@
             type=FileType("rt"),
             # TRANSLATORS: this is in imperative form
             help=_("load whitelist containing run patterns"))
+
+
+class JobIdCompleter:
+    """
+    An completer that compiles and provides a list of job definition
+    identifiers
+    """
+
+    def __init__(self, provider_list):
+        # TODO: add preview API that just contains job IDs
+        id_hints = set()
+        ns_hints = set()
+        for provider in provider_list:
+            for job in provider.load_all_jobs()[0]:
+                id_hints.add(job.id)
+                ns_hints.add(job.provider.namespace)
+        self.id_hints = id_hints
+        self.ns_hints = ns_hints
+
+    def __call__(self, prefix, **kwargs):
+        prefix = prefix.replace('\\:', ':')
+        if "::" in prefix:
+            return sorted(c for c in self.id_hints if c.startswith(prefix))
+        else:
+            return sorted(c + '::' for c in self.ns_hints if c.startswith(prefix))

=== modified file 'plainbox/plainbox/impl/commands/run.py'
--- plainbox/plainbox/impl/commands/run.py	2014-08-04 16:51:44 +0000
+++ plainbox/plainbox/impl/commands/run.py	2014-08-08 12:19:52 +0000
@@ -1020,4 +1020,4 @@
             help=_('comma-separated list of key-value options (k=v) to '
                    'be passed to the transport'))
         # Call enhance_parser from CheckBoxCommandMixIn
-        self.enhance_parser(parser)
+        self.enhance_parser(parser, self.provider_list)

=== modified file 'plainbox/requirements/pip-optional.txt'
--- plainbox/requirements/pip-optional.txt	2014-01-30 09:12:57 +0000
+++ plainbox/requirements/pip-optional.txt	2014-08-08 12:19:52 +0000
@@ -1,1 +1,1 @@
-# argcomplete==0.5.4
+argcomplete==0.8.1

=== modified file 'support/external-tarballs-revision.txt'
--- support/external-tarballs-revision.txt	2014-04-04 16:31:35 +0000
+++ support/external-tarballs-revision.txt	2014-08-08 12:19:52 +0000
@@ -1,1 +1,1 @@
-e73394e83aff317c77e003cf9b33ac8aa3372297
+94eb2109d47da28d32915d523a6081ebf9bdcf02