lp:~zyga/checkbox/attachment-fixes
- Get this branch:
- bzr branch lp:~zyga/checkbox/attachment-fixes
Branch merges
- Daniel Manrique (community): Needs Information
- Sylvain Pineau (community): Approve
-
Diff: 121 lines (+73/-3)3 files modifiedplainbox/plainbox/impl/providers/stubbox/manage.py (+2/-1)
plainbox/plainbox/impl/providers/stubbox/units/jobs/stub.pxu (+59/-0)
plainbox/plainbox/vendor/extcmd/glibc.py (+12/-2)
Related bugs
Bug #1401886: BlockingIOError: [Errno 11] write could not complete without blocking | Critical | Fix Released |
Related blueprints
Branch information
Recent revisions
- 3502. By Zygmunt Krynicki
-
plainbox:excmd: don't expose non-blocking pipes to children
This patch fixes a bug in the glibc-based extcmd implementation.
The communication pipes that are created to pass stdout and stderr data
were created in non-blocking mode and that non-blocking pipe was exposed
to the child process. A child process writing fast enough could fill the
pipe and get EAGAIN. Since applications are not generally designed to
handle that it would cause random failures.The fix based on creating normal (blocking) pipes and only set the
non-blocking mode in the parent process that has an event loop.Fixes: https:/
/bugs.launchpad .net/plainbox/ +bug/1401886 Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3501. By Zygmunt Krynicki
-
plainbox:
providers: stubbox: add test attachment jobs This patch adds a collection of stubbox jobs for testing attachments.
stub/
text-attachment : prints (and captures) a small UTF-8 encoded
piece of text. It can catch errors in handling output encodingstub/
large-text- attachment: prints (and captures) a large UTF-8
encoded piece of text. It can catch errors related to buffering.stub/
binary- attachment: prints (and captures) a
specifically-difficult- to-handle binary data consisting of all 256
bytesstub/
large-binary- attachment: prints (and captures) a large binary
blob to test handling of memory efficiency.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3500. By Zygmunt Krynicki
-
plainbox:
providers: stubbox: disable strict validation Strict validation will never work on stubbox, because it's full of
representative data, including deprecated constructs.Signed-off-by: Zygmunt Krynicki <email address hidden>
- 3499. By Zygmunt Krynicki
-
"automatic merge of lp:~zkrynicki/checkbox/extcmd-abnormal-end/ by tarmac [r=sylvain-
pineau] [bug=][ author= zkrynicki] " - 3498. By Maciej Kisielewski
-
"automatic merge of lp:~kissiel/checkbox/fix-1399623/ by tarmac [r=zkrynicki][bug=1399623][author=kissiel]"
- 3497. By Sylvain Pineau
-
"automatic merge of lp:~sylvain-pineau/checkbox/export_flags/ by tarmac [r=zkrynicki]
[bug=][ author= sylvain- pineau] " - 3496. By Zygmunt Krynicki
-
"automatic merge of lp:~zkrynicki/checkbox/glibc-extcmd/ by tarmac [r=sylvain-
pineau] [bug=][ author= zkrynicki] " - 3495. By Sylvain Pineau
-
"automatic merge of lp:~sylvain-pineau/checkbox/client-cert-regression/ by tarmac [r=zkrynicki]
[bug=][ author= sylvain- pineau] " - 3494. By Maciej Kisielewski
-
"automatic merge of lp:~kissiel/checkbox/common-dialog/ by tarmac [r=zkrynicki]
[bug=][ author= kissiel] " - 3493. By Zygmunt Krynicki
-
"automatic merge of lp:~zkrynicki/checkbox/test-plan-fixes/ by tarmac [r=roadmr]
[bug=][ author= zkrynicki] "
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:checkbox