Next Generation Checkbox (CLI)

Merge ~zyga/checkbox-ng:fix/quoting-startprovider into checkbox-ng:master

  1. Git
  2. lp:~zyga/checkbox-ng
  3. fix/quoting-startprovider
  4. Merge into master
Proposed by Zygmunt Krynicki
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 087e8c4bf5b4136f29f8220c36013f124bd6a7dd
Merged at revision: 7b3c2b0f7bdb2597f1010950c75f8b9c7bfd8ec9
Proposed branch: ~zyga/checkbox-ng:fix/quoting-startprovider
Merge into: checkbox-ng:master
Diff against target: 13 lines (+1/-1)
1 file modified
checkbox_ng/launcher/startprovider.py (+1/-1)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+426392@code.launchpad.net

Description of the change

Generating a new plainbox test provider should not make the provider fail internal verification with "./manage.py test". This patch fixes a shellcheck quote issue that is currently reported on all the newly created providers.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Makes sense, thanks! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_ng/launcher/startprovider.py b/checkbox_ng/launcher/startprovider.py
2index ddc2974..d2ad4f7 100644
3--- a/checkbox_ng/launcher/startprovider.py
4+++ b/checkbox_ng/launcher/startprovider.py
5@@ -314,7 +314,7 @@ class ProviderSkeleton(EmptyProviderSkeleton):
6 plugin: shell
7 estimated_duration: 0.01
8 command:
9- test "$(cat $PLAINBOX_PROVIDER_DATA/example.dat)" = "DATA"
10+ test "$(cat "$PLAINBOX_PROVIDER_DATA"/example.dat)" = "DATA"
11 flags: preserve-locale
12
13 unit: job

Subscribers

People subscribed via source and target branches