Merge lp:~zulcss/ubuntu/jaunty/nut/sru-416812 into lp:ubuntu/jaunty/nut

Proposed by Chuck Short
Status: Needs review
Proposed branch: lp:~zulcss/ubuntu/jaunty/nut/sru-416812
Merge into: lp:ubuntu/jaunty/nut
Diff against target: 33 lines (+10/-3)
2 files modified
debian/changelog (+7/-0)
debian/nut.init (+3/-3)
To merge this branch: bzr merge lp:~zulcss/ubuntu/jaunty/nut/sru-416812
Reviewer Review Type Date Requested Status
Steve Beattie (community) sru Approve
Review via email: mp+12722@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Beattie (sbeattie) wrote :

One minor nit: I think the SRU version should be 2.4.1-2ubuntu4.1 rather than 2.4.1-2ubuntu5, but in this case I believe it's okay given that based on https://launchpad.net/ubuntu/+source/nut/+changelog, it doesn't appear that there was a 2.4.1-2ubuntu5 in the karmic dev cycle.

Otherwise, fix looks good.

review: Approve (sru)
Revision history for this message
Steve Beattie (sbeattie) wrote :

One other comment: please update the bug report description(s) with the justification and testcase/steps to reproduce rather than just adding a comment; in particularly comment heavy bugs, in can be hard to dig those out (it also makes it more difficult to write scripts to tease out relevant information about SRUs). Thanks!

38. By Chuck Short

Fix debian/changelog

Unmerged revisions

38. By Chuck Short

Fix debian/changelog

37. By Chuck Short

debian/init: Fix status_of_proc messages not to lie to the user
(LP: #416182)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-04-09 14:01:54 +0000
3+++ debian/changelog 2009-11-09 14:08:11 +0000
4@@ -1,3 +1,10 @@
5+nut (2.4.1-2ubuntu4.1) jaunty-proposed; urgency=low
6+
7+ * debian/init: Fix status_of_proc messages not to lie to the user
8+ (LP: #416182)
9+
10+ -- Chuck Short <zulcss@ubuntu.com> Thu, 01 Oct 2009 10:19:02 -0400
11+
12 nut (2.4.1-2ubuntu4) jaunty; urgency=low
13
14 * debian/nut.links: must create the init script link, used if the ups
15
16=== modified file 'debian/nut.init'
17--- debian/nut.init 2009-02-27 12:49:24 +0000
18+++ debian/nut.init 2009-11-09 14:08:11 +0000
19@@ -65,11 +65,11 @@
20 check_status() {
21 case "$MODE" in
22 standalone|netserver)
23- status_of_proc "$DESC" upsd
24- status_of_proc "$DESC" upsmon
25+ status_of_proc -p $upsd_pid $upsd upsd
26+ status_of_proc -p $upsmon_pid $upsmon upsmon
27 ;;
28 netclient)
29- status_of_proc "$DESC" upsmon
30+ status_of_proc -p $upsmon_pid $upsmon upsmon
31 ;;
32 none|*)
33 ;;

Subscribers

People subscribed via source and target branches

to all changes: