Merge lp:~zulcss/python-neutronclient/rename into lp:~ubuntu-server-dev/python-neutronclient/havana
Proposed by
Chuck Short
Status: | Merged |
---|---|
Merged at revision: | 43 |
Proposed branch: | lp:~zulcss/python-neutronclient/rename |
Merge into: | lp:~ubuntu-server-dev/python-neutronclient/havana |
Diff against target: |
114 lines (+26/-17) 5 files modified
debian/changelog (+8/-1) debian/control (+10/-9) debian/copyright (+2/-4) debian/rules (+3/-0) debian/watch (+3/-3) |
To merge this branch: | bzr merge lp:~zulcss/python-neutronclient/rename |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Approve | ||
Review via email: mp+173715@code.launchpad.net |
To post a comment you must log in.
Hey Chuck
Firstly, can you have a tidy of the following lintian warnings/errors:
E: python- quantumclient: copyright- contains- dh_make- todo-boilerplat e quantumclient: description- starts- with-leading- spaces neutronclient: debian- changelog- line-too- long line 5 neutronclient: copyright- contains- dh_make- todo-boilerplat e
N:
N: The string "Please also look if..." appears in the copyright file, which
N: indicates that you either didn't check the whole source to find
N: additional copyright/license, or that you didn't remove that paragraph
N: after having done so.
N:
N: Refer to Debian Policy Manual section 12.5 (Copyright information) for
N: details.
N:
N: Severity: serious, Certainty: possible
N:
N: Check: copyright-file, Type: binary
N:
W: python-
N:
N: The package "Description:" starts with leading spaces. Usually, leading
N: spaces are used to switch "verbatim display" on (i.e., lines are not
N: wrapped) so this might be a bug in the package.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: description, Type: binary, udeb
N:
W: python-
N:
N: The given line of the latest changelog entry is over 80 columns. Such
N: changelog entries may look poor in terminal windows and mail messages
N: and be annoying to read. Please wrap changelog entries at 80 columns or
N: less where possible.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: changelog-file, Type: binary
N:
E: python-