Merge lp:~zulcss/charms/trusty/lxd/lxd-ppa into lp:~openstack-charmers-archive/charms/trusty/lxd/next

Proposed by Chuck Short
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~zulcss/charms/trusty/lxd/lxd-ppa
Merge into: lp:~openstack-charmers-archive/charms/trusty/lxd/next
Diff against target: 25 lines (+3/-3)
2 files modified
config.yaml (+1/-1)
hooks/lxd_hooks.py (+2/-2)
To merge this branch: bzr merge lp:~zulcss/charms/trusty/lxd/lxd-ppa
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+286700@code.launchpad.net

Description of the change

Rename source to lxd-ppa so that it doesn't clobber other openstack config options.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #827 lxd-next for zulcss mp286700
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/
Build: http://10.245.162.36:8080/job/charm_unit_test/827/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #926 lxd-next for zulcss mp286700
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/926/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #374 lxd-next for zulcss mp286700
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/374/

Unmerged revisions

51. By Chuck Short

Rename source to lxd-origin not to clobber with other openstack config variables.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2015-10-02 11:59:06 +0000
3+++ config.yaml 2016-02-19 18:36:23 +0000
4@@ -1,5 +1,5 @@
5 options:
6- source:
7+ lxd-origin:
8 type: string
9 default:
10 description: |
11
12=== modified file 'hooks/lxd_hooks.py'
13--- hooks/lxd_hooks.py 2015-10-26 12:59:46 +0000
14+++ hooks/lxd_hooks.py 2016-02-19 18:36:23 +0000
15@@ -46,8 +46,8 @@
16 @hooks.hook()
17 def install():
18 status_set('maintenance', 'Installing LXD packages')
19- if config('source'):
20- add_source(config('source'))
21+ if config('lxd-origin'):
22+ add_source(config('lxd-origin'))
23 apt_update(fatal=True)
24 apt_install(determine_packages(), fatal=True)
25 if config('use-source'):

Subscribers

People subscribed via source and target branches