Merge lp:~zsombi/ubuntu-ui-toolkit/textfield-focusing-fix into lp:ubuntu-ui-toolkit

Proposed by Zsombor Egri
Status: Merged
Approved by: Tim Peeters
Approved revision: 333
Merged at revision: 335
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/textfield-focusing-fix
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 18 lines (+8/-0)
1 file modified
modules/Ubuntu/Components/TextField.qml (+8/-0)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/textfield-focusing-fix
Reviewer Review Type Date Requested Status
Tim Peeters Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+147348@code.launchpad.net

Commit message

Fixing TextField focusing when clicked/tapped between the frame and input

Description of the change

Fixing TextField focusing when clicked/tapped between the frame and input

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

its good.

why doesn't it get merged? I approved a few hours ago

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/TextField.qml'
2--- modules/Ubuntu/Components/TextField.qml 2013-02-07 13:23:25 +0000
3+++ modules/Ubuntu/Components/TextField.qml 2013-02-08 11:40:26 +0000
4@@ -399,6 +399,14 @@
5 control.focus = false;
6 }
7
8+ // grab clicks from the area between the frame and the input
9+ MouseArea {
10+ anchors.fill: parent
11+ // us it only when there is space between the frame and input
12+ enabled: internal.spacing > 0
13+ onClicked: editor.forceActiveFocus()
14+ }
15+
16 Text {
17 id: fontHolder
18 }

Subscribers

People subscribed via source and target branches

to status/vote changes: