Merge lp:~zsombi/ubuntu-ui-toolkit/tabBarTestFailureQt52 into lp:ubuntu-ui-toolkit

Proposed by Zsombor Egri
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 922
Merged at revision: 923
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/tabBarTestFailureQt52
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 10 lines (+0/-1)
1 file modified
tests/unit_x11/tst_components/tst_tabbar.qml (+0/-1)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/tabBarTestFailureQt52
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Timo Jyrinki Approve
Review via email: mp+202998@code.launchpad.net

Commit message

TabBar test case failure fix for Qt5.2

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
921. By Zsombor Egri

kick CI again

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Confirming success with Qt 5.2 + TabBarAPI tests in a local build, and this is a pre-requisite for further Qt 5.2 fixes.

review: Approve
922. By Zsombor Egri

trunk merge

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit_x11/tst_components/tst_tabbar.qml'
2--- tests/unit_x11/tst_components/tst_tabbar.qml 2013-12-03 13:09:14 +0000
3+++ tests/unit_x11/tst_components/tst_tabbar.qml 2014-01-25 06:12:03 +0000
4@@ -131,7 +131,6 @@
5 }
6
7 function test_0_selectionMode() {
8- waitForRendering(root);
9 compare(bar.selectionMode, true, "default selectionMode");
10 }
11

Subscribers

People subscribed via source and target branches

to status/vote changes: