Merge lp:~zsombi/ubuntu-ui-toolkit/servicecomponent-inclusion into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1370
Merged at revision: 1386
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/servicecomponent-inclusion
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 80 lines (+23/-3)
4 files modified
components.api (+12/-0)
modules/Ubuntu/Components/plugin/plugin.cpp (+2/-0)
modules/Ubuntu/Components/plugin/plugin.pro (+7/-2)
tests/unit_x11/unit_x11.pro (+2/-1)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/servicecomponent-inclusion
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+243621@code.launchpad.net

Commit message

Include ServiceProperties component into the module and the missing test case - inclusion messed up due to broken mainline in the previous branch.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1369. By Zsombor Egri

staging merge

1370. By Zsombor Egri

fixing project file

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components.api'
2--- components.api 2015-01-07 10:05:40 +0000
3+++ components.api 2015-01-22 06:26:45 +0000
4@@ -963,6 +963,18 @@
5 Property { name: "source"; type: "QUrl" }
6 Signal { name: "extendedSourceChanged" }
7 Signal { name: "extendedSourceChanged" }
8+ name: "UCServiceProperties"
9+ prototype: "QObject"
10+ exports: ["ServiceProperties 1.1"]
11+ name: "ServiceType"
12+ name: "Status"
13+ Property { name: "type"; revision: 1; type: "ServiceType" }
14+ Property { name: "service"; revision: 1; type: "string" }
15+ Property { name: "path"; revision: 1; type: "string" }
16+ Property { name: "serviceInterface"; revision: 1; type: "string" }
17+ Property { name: "adaptorInterface"; revision: 1; type: "string" }
18+ Property { name: "error"; revision: 1; type: "string"; isReadonly: true }
19+ Property { name: "status"; revision: 1; type: "Status"; isReadonly: true }
20 name: "UCStateSaver"
21 prototype: "QObject"
22 exports: ["StateSaver 0.1", "StateSaver 1.0"]
23
24=== modified file 'modules/Ubuntu/Components/plugin/plugin.cpp'
25--- modules/Ubuntu/Components/plugin/plugin.cpp 2015-01-06 06:11:00 +0000
26+++ modules/Ubuntu/Components/plugin/plugin.cpp 2015-01-22 06:26:45 +0000
27@@ -56,6 +56,7 @@
28 #include "uclistitem_p.h"
29 #include "uclistitemactions.h"
30 #include "uclistitemstyle.h"
31+#include "ucserviceproperties.h"
32
33 #include <sys/types.h>
34 #include <unistd.h>
35@@ -166,6 +167,7 @@
36 qmlRegisterType<QSortFilterProxyModelQML>(uri, 1, 1, "SortFilterModel");
37 qmlRegisterUncreatableType<FilterBehavior>(uri, 1, 1, "FilterBehavior", "Not instantiable");
38 qmlRegisterUncreatableType<SortBehavior>(uri, 1, 1, "SortBehavior", "Not instantiable");
39+ qmlRegisterType<UCServiceProperties, 1>(uri, 1, 1, "ServiceProperties");
40
41 // ListItem and related types, released to 1.2
42 qmlRegisterType<UCListItem, 2>(uri, 1, 2, "ListItem");
43
44=== modified file 'modules/Ubuntu/Components/plugin/plugin.pro'
45--- modules/Ubuntu/Components/plugin/plugin.pro 2015-01-07 07:41:29 +0000
46+++ modules/Ubuntu/Components/plugin/plugin.pro 2015-01-22 06:26:45 +0000
47@@ -72,7 +72,10 @@
48 uclistitemactions.h \
49 uclistitemactions_p.h \
50 propertychange_p.h \
51- uclistitemstyle.h
52+ uclistitemstyle.h \
53+ adapters\dbuspropertywatcher_p.h \
54+ ucserviceproperties.h \
55+ ucserviceproperties_p.h
56
57 SOURCES += plugin.cpp \
58 uctheme.cpp \
59@@ -115,7 +118,9 @@
60 uclistitemstyle.cpp \
61 ucviewitemsattached.cpp \
62 uclistitemattached.cpp \
63- ucactionpanel_p.cpp
64+ ucactionpanel_p.cpp \
65+ adapters\dbuspropertywatcher_p.cpp \
66+ ucserviceproperties.cpp
67
68 # adapters
69 SOURCES += adapters/alarmsadapter_organizer.cpp
70
71=== modified file 'tests/unit_x11/unit_x11.pro'
72--- tests/unit_x11/unit_x11.pro 2014-12-03 14:43:27 +0000
73+++ tests/unit_x11/unit_x11.pro 2015-01-22 06:26:45 +0000
74@@ -11,4 +11,5 @@
75 tst_orientation \
76 tst_layouts \
77 tst_mousefilters \
78- tst_animator
79+ tst_animator \
80+ tst_serviceproperties

Subscribers

People subscribed via source and target branches